From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20765 invoked by alias); 3 Mar 2002 15:14:01 -0000 Mailing-List: contact libc-hacker-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-hacker-owner@sources.redhat.com Received: (qmail 20714 invoked from network); 3 Mar 2002 15:13:59 -0000 Received: from unknown (HELO Cantor.suse.de) (213.95.15.193) by sources.redhat.com with SMTP; 3 Mar 2002 15:13:59 -0000 Received: from Hermes.suse.de (Hermes.suse.de [213.95.15.136]) by Cantor.suse.de (Postfix) with ESMTP id BD26F1E413 for ; Sun, 3 Mar 2002 16:13:58 +0100 (MET) Received: from aj by arthur.inka.de with local (Exim 3.34 #1) id 16hXJC-00048n-00 for libc-hacker@sources.redhat.com; Sun, 03 Mar 2002 15:49:54 +0100 To: GNU libc hacker Subject: Fix a number of warnings From: Andreas Jaeger Date: Sun, 03 Mar 2002 07:14:00 -0000 Message-ID: User-Agent: Gnus/5.090006 (Oort Gnus v0.06) XEmacs/21.4 (Artificial Intelligence, i386-suse-linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2002-03/txt/msg00019.txt.bz2 On x86-64 cross builds and on x86 native builds I got these (and similar) warnings which the appended patch fixes: ../sysdeps/wordsize-32/divdi3.c:272: warning: no previous prototype for `__divdi3' ../sysdeps/wordsize-32/divdi3.c:294: warning: no previous prototype for `__moddi3' ../sysdeps/wordsize-32/divdi3.c:316: warning: no previous prototype for `__udivdi3' ../sysdeps/wordsize-32/divdi3.c:322: warning: no previous prototype for `__umoddi3' ../linuxthreads/sysdeps/i386/i686/pt-machine.h:38: warning: no previous prototype for `testandset' ../linuxthreads/sysdeps/i386/i686/pt-machine.h:56: warning: no previous prototype for `__compare_and_swap' td_thr_set_event.c:34: warning: implicit declaration of function `__libc_write' error.c:201: warning: implicit declaration of function `_IO_putc_internal' Ok to commit? Andreas 2002-03-03 Andreas Jaeger * sysdeps/wordsize-32/divdi3.c: Add prototypes to avoid warnings. * misc/error.c [_LIBC]: Include libioP.h for prototype of _IO_putc_internal. * linuxthreads_db/thread_dbP.h: Include for prototypes of __libc_write. For linuxthreads: * sysdeps/i386/tls.h: Include for prototypes. ============================================================ Index: misc/error.c --- misc/error.c 2002/02/26 01:43:53 1.29 +++ misc/error.c 2002/03/03 14:09:15 @@ -74,6 +74,7 @@ unsigned int error_message_count; # define program_name program_invocation_name # include +# include /* In GNU libc we want do not want to use the common name `error' directly. Instead make it a weak alias. */ ============================================================ Index: linuxthreads/sysdeps/i386/tls.h --- linuxthreads/sysdeps/i386/tls.h 2002/02/24 04:56:52 1.9 +++ linuxthreads/sysdeps/i386/tls.h 2002/03/03 14:09:15 @@ -21,7 +21,7 @@ #define _TLS_H #include - +#include #include /* Type for the dtv. */ ============================================================ Index: sysdeps/wordsize-32/divdi3.c --- sysdeps/wordsize-32/divdi3.c 2002/02/28 19:36:29 1.1 +++ sysdeps/wordsize-32/divdi3.c 2002/03/03 14:09:15 @@ -50,6 +50,12 @@ struct DWstruct { Wtype low, high;}; #endif typedef union { struct DWstruct s; DWtype ll; } DWunion; +/* Prototypes of exported functions. */ +extern DWtype __divdi3 (DWtype u, DWtype v); +extern DWtype __moddi3 (DWtype u, DWtype v); +extern UDWtype __udivdi3 (UDWtype u, UDWtype v); +extern UDWtype __umoddi3 (UDWtype u, UDWtype v); + static UDWtype __udivmoddi4 (UDWtype n, UDWtype d, UDWtype *rp) { ============================================================ Index: linuxthreads_db/thread_dbP.h --- linuxthreads_db/thread_dbP.h 2002/02/05 00:50:51 1.10 +++ linuxthreads_db/thread_dbP.h 2002/03/03 14:09:15 @@ -3,6 +3,7 @@ #define _THREAD_DBP_H 1 #include +#include #include "proc_service.h" #include "thread_db.h" #include "../linuxthreads/descr.h" -- Andreas Jaeger SuSE Labs aj@suse.de private aj@arthur.inka.de http://www.suse.de/~aj