public inbox for libc-hacker@sourceware.org
 help / color / mirror / Atom feed
From: Joel Klecker <jk@espy.org>
To: GNU libc hacker <libc-hacker@sourceware.cygnus.com>
Subject: Re: prepare for 2.1.3
Date: Wed, 10 Nov 1999 14:56:00 -0000	[thread overview]
Message-ID: <v04220802b44fa7fb5285@[206.163.71.146]> (raw)
In-Reply-To: <m3g0yeoydo.fsf@localhost.localnet>

At 13:00 -0800 1999-11-10, Ulrich Drepper wrote:
>Joel Klecker <jk@espy.org> writes:
>
>> You don't appear to have fixed the issue I found with --with-headers 
>> and linuxthreads/signals.c yet.
>
>You'll have to elaborate this.  I don't think I have anything about
>this in my mail folders.

Here's the message I sent:

<<
Date: Fri, 22 Oct 1999 00:10:19 -0700
To: libc-hacker@sourceware.cygnus.com
From: Joel Klecker <jk@espy.org>
Subject: Current glibc-2-1-branch linuxthreads/signals.c doesn't compile

Without --with-headers, <ucontext.h> ends up being gotten from the system
headers, which is perhaps why this wasn't caught before.
linuxthreads/signals.c doesn't appear to need any of the functions prototyped in
<ucontext.h>, so I believe this is the correct fix.

1999-10-22 Joel Klecker <espy@debian.org>

	* signals.c: Include <sys/ucontext.h> instead of <ucontext.h>.

Index: linuxthreads/signals.c
===================================================================
RCS file: /cvs/glibc/libc/linuxthreads/signals.c,v
retrieving revision 1.8.2.3
diff -u -r1.8.2.3 signals.c
--- linuxthreads/signals.c	1999/09/25 16:59:50	1.8.2.3
+++ linuxthreads/signals.c	1999/10/22 06:54:36
@@ -19,7 +19,7 @@
 #include "pthread.h"
 #include "internals.h"
 #include "spinlock.h"
-#include <ucontext.h>
+#include <sys/ucontext.h>
 #include <sigcontextinfo.h>
 
 int pthread_sigmask(int how, const sigset_t * newmask, sigset_t * oldmask)
-- 
Joel Klecker (aka Espy)       <URL: mailto:espy@debian.org >
Debian Package Maintainer for the GNU C Library.
>>

And your reply:

<<
To: Joel Klecker <jk@espy.org>
Cc: libc-hacker@sourceware.cygnus.com
Subject: Re: Current glibc-2-1-branch linuxthreads/signals.c doesn't compile
Reply-To: drepper@cygnus.com (Ulrich Drepper)
X-fingerprint: BE 3B 21 04 BC 77 AC F0  61 92 E4 CB AC DD B9 5A
From: Ulrich Drepper <drepper@cygnus.com>
Date: 23 Oct 1999 10:04:53 -0700

Joel Klecker <jk@espy.org> writes:

> linuxthreads/signals.c doesn't appear to need any of the functions
> prototyped in <ucontext.h>, so I believe this is the correct fix.

I prefer to have the real heade included and so I make the same change
as for 2.2 (where I fixed this already some time ago).

-- 
---------------.      drepper at gnu.org  ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Cygnus Solutions `--' drepper at cygnus.com   `------------------------
>>
-- 
Joel Klecker (aka Espy)                    Debian GNU/Linux Developer
<URL: mailto:jk@espy.org >                 <URL: mailto:espy@debian.org >
<URL: http://web.espy.org/ >               <URL: http://www.debian.org/ >

      reply	other threads:[~1999-11-10 14:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
1999-11-10  0:17 Ulrich Drepper
1999-11-10 12:53 ` Joel Klecker
1999-11-10 13:03   ` Ulrich Drepper
1999-11-10 14:56     ` Joel Klecker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='v04220802b44fa7fb5285@[206.163.71.146]' \
    --to=jk@espy.org \
    --cc=libc-hacker@sourceware.cygnus.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).