From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.bonedaddy.net (smtp.bonedaddy.net [45.33.94.42]) by sourceware.org (Postfix) with ESMTPS id E4D10385841C for ; Mon, 7 Aug 2023 11:01:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4D10385841C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=bonedaddy.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=bonedaddy.net Received: by smtp.bonedaddy.net (Postfix, from userid 10001) id 274113020D8; Mon, 7 Aug 2023 06:55:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bonedaddy.net; s=mail; t=1691405725; bh=sEMnpBfB9jUU2APxyeymbeMV7MeVaEFLHgfC/cGWuXU=; h=Subject:From:Reply-To:To:In-Reply-To:References:Date; b=BxVKCseS9nwK/nVIE5LWIzw7bS8IUyak0L8O1zgbC9SeTNNw+X+ZNEXaMDaALkR2j 7f256fJLYEG5Rc+gAZPp0APavG7d/3mbaVlLmvCtlCxl0RM/nwfQNij9oLuB0xqT83 6ZEIVSOX+n98XG01FewZpJqQjFRukONR2pEZnAwO5upG8GtjqPkTqCeTAfotTOxIJK P3h6PUbzpiRpg9zLvYXQT80KQ3+xdN3UE/EDfUmVH+F6VLij3gA/EUKeaDQEWKq9K/ jV9mCelbOYcqNfTs3XaYeWERzPSoMF8kXNVAKj2MxdUTYCZRxQzx5PMKVrZ6lgOZ+y c6B6YiPgBBMyQ== Message-ID: <161b0b6563925702c3fda431ae703d0aa395b60a.camel@bonedaddy.net> Subject: Re: is this a bug in glibc or readpst? From: Paul Wise Reply-To: Florian Weimer , Libc-help To: Florian Weimer , Libc-help In-Reply-To: <874jlbi5x0.fsf@oldenburg.str.redhat.com> References: <2cefc4fa95dd439c2581f4f06d520c004cd33708.camel@bonedaddy.net> <875yf6nj43.fsf@oldenburg.str.redhat.com> <87ilitpv06.fsf@oldenburg.str.redhat.com> <874jlbi5x0.fsf@oldenburg.str.redhat.com> Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-E/ma91BQJKWghL51eTLC" Date: Mon, 07 Aug 2023 19:00:47 +0800 MIME-Version: 1.0 User-Agent: Evolution 3.48.4-1 X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --=-E/ma91BQJKWghL51eTLC Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, 2023-08-07 at 10:59 +0200, Florian Weimer wrote: > We could perhaps avoid the seek for read-only streams.=C2=A0 We are about= to > close the stream anyway, so fflush does not have any useful effect > anyway.=C2=A0 Not sure what others think if it is worth the complexity.= =C2=A0 On > the other hand, preserving backwards compatibility here does not appear > to be too onerous. It might be worth checking what other implementations do, perhaps if they all avoid the seek in this case then maybe glibc should too? --=20 bye, pabs https://bonedaddy.net/pabs3/ --=-E/ma91BQJKWghL51eTLC Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEYQsotVz8/kXqG1Y7MRa6Xp/6aaMFAmTQztsACgkQMRa6Xp/6 aaNMQA//dY5RYvhtfqHvJNERaHp5s+n9z4Ll0Rba25+Q+hAzHKnj3pB+tZBs63Xt vsRA8u3DzICqLPIrCRriaQlqlR2CUXRICVx3+C5Kr5XmDTR8dZw0gvdeB/RZAsHc vtKuVz0eBHYs10ZbCbzWda9duaziBMlck3S7ULPvc1YqRJnRCdiI8BBv10l9RS9R c8XsZ+KaKEEYX9+W1tvxZBA3kZlJDk3Fvmsz3bklYNSZtJduiC2jFWwyfCEPZoBh coW42cxoNzFQLSX+Cz7kOXkgnD3hLfHCdpwiX0EIlW2xwkJeU43tbd5FJaN0c6nS wbRL7IQgk0i+bso7cxqRfL6cpKI8IUJN13JN/Bj6KlRPOr+uu/XPX10reBzkZo/t UP1maF2M7vafheBbI/ZSb2TiEyaBc7bZjtW2rFdkBJELrzZC6hFI1NJzxN4fv1vy rHbgMEQmp6phJan0iXaBhmOT1Zpez92eDcjU8xNLQAzm7G3icS/yOvnsbrL8j4Nc lPGAqAn+Kr2AfFxYlaPf3c9Aypnn7qvYqFk7Lzi0yCu0S66E59VlfmIYCpi0tFLX ndoJnEOhYM0Va8nBYFc5ih/nFJzJC9+ltIpKTRbfVOnyrFSm7tXrLwirrxIdgqDG 85Vo4vyo8PEequ0gUMbMLnujfto1PwkPYBE6S+a1sIl0AJPMv4g= =JkZe -----END PGP SIGNATURE----- --=-E/ma91BQJKWghL51eTLC--