From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13816 invoked by alias); 13 Dec 2019 14:05:24 -0000 Mailing-List: contact libc-help-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: libc-help-owner@sourceware.org Received: (qmail 13801 invoked by uid 89); 13 Dec 2019 14:05:24 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 spammy=H*Ad:U*libc-help, 54, Director, director X-HELO: mail-out.m-online.net Received: from mail-out.m-online.net (HELO mail-out.m-online.net) (212.18.0.9) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 14:05:21 +0000 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 47ZC9W4zFfz1qvjp; Fri, 13 Dec 2019 15:05:19 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 47ZC9W487hz1rYZf; Fri, 13 Dec 2019 15:05:19 +0100 (CET) Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id XFKkBBqoQnrG; Fri, 13 Dec 2019 15:05:17 +0100 (CET) Received: from jawa (85-222-111-42.dynamic.chello.pl [85.222.111.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Fri, 13 Dec 2019 15:05:17 +0100 (CET) Date: Fri, 13 Dec 2019 14:05:00 -0000 From: Lukasz Majewski To: Manuel Lauss Cc: libc-help@sourceware.org, Adhemerval Zanella , Alistair Francis Subject: Re: 32bit builds broken by gettime64 vDSO patches Message-ID: <20191213150511.2ebeb898@jawa> In-Reply-To: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/GD70dSKMgYb24ZV=L+nXJ.4"; protocol="application/pgp-signature" X-IsSubscribed: yes X-SW-Source: 2019-12/txt/msg00017.txt.bz2 --Sig_/GD70dSKMgYb24ZV=L+nXJ.4 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Content-length: 4505 Hi Manuel, > Hello, >=20 > 32bit builds of latest git head (tested x86, MIPS o32, ARM, SH4) > break on my system; 64 bit (arm64, x86_64) builds are fine. > Reverting Alistair Francis' 2 clock_gettime64 patches fixes that. >=20 > In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: > ../sysdeps/unix/sysv/linux/clock_gettime.c: In function > =E2=80=98__clock_gettime64=E2=80=99: ../sysdeps/unix/sysv/linux/sysdep-vd= so.h:40:15: > error: =E2=80=98__vdso_clock_gettime64=E2=80=99 undeclared (first use in = this > function); did you mean =E2=80=98__vdso_clock_gettime=E2=80=99? > 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ > | ^~~~~~~ > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > | ^~~~~~~~~~~~~~~ > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:40:15: note: each undeclared > identifier is reported only once for each function it appears in > 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ > | ^~~~~~~ > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > | ^~~~~~~~~~~~~~~ > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:42:15: warning: comparison > between pointer and integer > 42 | if (vdsop !=3D NULL) \ > | ^~ > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > | ^~~~~~~~~~~~~~~ > In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:44:35: error: called object > =E2=80=98vdsop=E2=80=99 is not a function or function pointer > 44 | sc_ret =3D INTERNAL_VSYSCALL_CALL (vdsop, sc_err, nr, ##args); > \ | ^~~~~ > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:26:6: note: in definition of > macro =E2=80=98INTERNAL_VSYSCALL_CALL=E2=80=99 > 26 | funcptr (args) > | ^~~~~~~ > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > | ^~~~~~~~~~~~~~~ > In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:40:30: note: declared here > 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ > | ^~~~~ > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > | ^~~~~~~~~~~~~~~ > make[2]: *** > [/tmp-ram/portage/sys-libs/glibc-2.30-r3/work/build-x86-x86_64-pc-linux-g= nu-nptl/sysd-rules:213: > /tmp-ram/portage/sys-libs/glibc-2.30-r3/work/build-x86-x86_64-pc-linux-gn= u-nptl/time/clock_gettime.o] > Error 1 make[2]: Leaving directory > '/tmp-ram/portage/sys-libs/glibc-2.30-r3/work/glibc-2.30/time' >=20 > glibc is configured thusly: > configure --enable-stack-protector=3Dno > --enable-stackguard-randomization --disable-cet --enable-kernel=3D5.2.0 > --without-selinux --without-cvs --disable-werror --enable-bind-now > --build=3Di686-pc-linux-gnu --host=3Di686-pc-linux-gnu --disable-profile > --without-gd --with-headers=3D/usr/include --prefix=3D/usr > --sysconfdir=3D/etc --localstatedir=3D/var --libdir=3D$(prefix)/lib > --mandir=3D$(prefix)/share/man --infodir=3D$(prefix)/share/info > --libexecdir=3D$(libdir)/misc/glibc > --with-bugurl=3Dhttps://bugs.gentoo.org/ --with-pkgversion=3DGentoo > 2.30-r3 p4 --enable-crypt --disable-systemtap --disable-nscd > --disable-timezone-tools >=20 Do you use kernel headers > 5.1 but < 5.4 (32 bit) ?=20 For 32 bit devices there is a fix available: https://github.com/lmajewski/y2038_glibc/commit/93a26fc4b3c4c3f57dec539d1f3= 244f7ae417be3 >=20 > Thanks! > Manuel Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de --Sig_/GD70dSKMgYb24ZV=L+nXJ.4 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature Content-length: 484 -----BEGIN PGP SIGNATURE----- iQEyBAEBCgAdFiEEgAyFJ+N6uu6+XupJAR8vZIA0zr0FAl3zmpcACgkQAR8vZIA0 zr1Npwf4hsITni1WVJb5y6CuIU2ttMxvO4MOYmXkua+dObuhnxqeVaH1qgQzrkLE N8qrzkReyqtD9D1PDnvOWXnZxFFeyCeSSwjQDB6n1EcFft4Tx6JOJdJ6WMr8Ps8N ZLGv7aNssdrfEl3VHBnXhah4MyNtJ442LnflD9aatDOrPggg+AGyOT6a2lnPjGAg mUiHr8zcFAgiQE5tI4uSRDEjbN9wg1Cs1vs19NNYd7HIN0f+QFcRYfY3vi626w2J JYxcraBqeFv6Hm4XFaaqHtXtHxKFx0NAPuhstPgAFdFs3evqcyeNcgHnkWgRoZdS tYh6+yiOy4EbIfcAgj+nHrosX82Z =3aVL -----END PGP SIGNATURE----- --Sig_/GD70dSKMgYb24ZV=L+nXJ.4--