From: Prem Mallappa <prem.mallappa@gmail.com>
To: libc-help@sourceware.org, codonell@redhat.com, schwab@suse.com,
FWeimer@redhat.com
Cc: Prem Mallappa <Premachandra.Mallappa@amd.com>
Subject: [PATCH 1/3] x86: Refactor platform support in cpu_features
Date: Mon, 16 Mar 2020 12:14:06 +0530 [thread overview]
Message-ID: <20200316064408.13808-2-PMallappa@amd.com> (raw)
In-Reply-To: <20200316064408.13808-1-PMallappa@amd.com>
From: Prem Mallappa <Premachandra.Mallappa@amd.com>
This is a preliminary support to have platform
for AMD processors.
Signed-off-by: Prem Mallappa <Premachandra.Mallappa@amd.com>
---
sysdeps/x86/cpu-features.c | 99 ++++++++++++++++++++------------------
1 file changed, 53 insertions(+), 46 deletions(-)
diff --git a/sysdeps/x86/cpu-features.c b/sysdeps/x86/cpu-features.c
index 81a170a819..a36f385976 100644
--- a/sysdeps/x86/cpu-features.c
+++ b/sysdeps/x86/cpu-features.c
@@ -302,6 +302,58 @@ _Static_assert (((index_arch_Fast_Unaligned_Load
== index_arch_Fast_Copy_Backward)),
"Incorrect index_arch_Fast_Unaligned_Load");
+static void
+set_platform (struct cpu_features *cpu_features)
+{
+#ifdef __x86_64__
+ const char *platform = NULL;
+
+ GLRO(dl_hwcap) = HWCAP_X86_64;
+
+ if (cpu_features->basic.kind == arch_kind_intel)
+ {
+ if (CPU_FEATURES_ARCH_P (cpu_features, AVX512F_Usable)
+ && CPU_FEATURES_CPU_P (cpu_features, AVX512CD))
+ {
+ if (CPU_FEATURES_CPU_P (cpu_features, AVX512ER))
+ {
+ if (CPU_FEATURES_CPU_P (cpu_features, AVX512PF))
+ platform = "xeon_phi";
+ }
+ else
+ {
+ if (CPU_FEATURES_CPU_P (cpu_features, AVX512BW)
+ && CPU_FEATURES_CPU_P (cpu_features, AVX512DQ)
+ && CPU_FEATURES_CPU_P (cpu_features, AVX512VL))
+ GLRO(dl_hwcap) |= HWCAP_X86_AVX512_1;
+ }
+ }
+
+ if (platform == NULL
+ && CPU_FEATURES_ARCH_P (cpu_features, AVX2_Usable)
+ && CPU_FEATURES_ARCH_P (cpu_features, FMA_Usable)
+ && CPU_FEATURES_CPU_P (cpu_features, BMI1)
+ && CPU_FEATURES_CPU_P (cpu_features, BMI2)
+ && CPU_FEATURES_CPU_P (cpu_features, LZCNT)
+ && CPU_FEATURES_CPU_P (cpu_features, MOVBE)
+ && CPU_FEATURES_CPU_P (cpu_features, POPCNT))
+ platform = "haswell";
+ }
+
+ if (platform != NULL)
+ GLRO(dl_platform) = platform;
+#else
+ GLRO(dl_hwcap) = 0;
+ if (CPU_FEATURES_CPU_P (cpu_features, SSE2))
+ GLRO(dl_hwcap) |= HWCAP_X86_SSE2;
+
+ if (CPU_FEATURES_ARCH_P (cpu_features, I686))
+ GLRO(dl_platform) = "i686";
+ else if (CPU_FEATURES_ARCH_P (cpu_features, I586))
+ GLRO(dl_platform) = "i586";
+#endif
+}
+
static inline void
init_cpu_features (struct cpu_features *cpu_features)
{
@@ -506,52 +558,7 @@ no_cpuid:
GLRO(dl_hwcap_mask) = HWCAP_IMPORTANT;
#endif
-#ifdef __x86_64__
- GLRO(dl_hwcap) = HWCAP_X86_64;
- if (cpu_features->basic.kind == arch_kind_intel)
- {
- const char *platform = NULL;
-
- if (CPU_FEATURES_ARCH_P (cpu_features, AVX512F_Usable)
- && CPU_FEATURES_CPU_P (cpu_features, AVX512CD))
- {
- if (CPU_FEATURES_CPU_P (cpu_features, AVX512ER))
- {
- if (CPU_FEATURES_CPU_P (cpu_features, AVX512PF))
- platform = "xeon_phi";
- }
- else
- {
- if (CPU_FEATURES_CPU_P (cpu_features, AVX512BW)
- && CPU_FEATURES_CPU_P (cpu_features, AVX512DQ)
- && CPU_FEATURES_CPU_P (cpu_features, AVX512VL))
- GLRO(dl_hwcap) |= HWCAP_X86_AVX512_1;
- }
- }
-
- if (platform == NULL
- && CPU_FEATURES_ARCH_P (cpu_features, AVX2_Usable)
- && CPU_FEATURES_ARCH_P (cpu_features, FMA_Usable)
- && CPU_FEATURES_CPU_P (cpu_features, BMI1)
- && CPU_FEATURES_CPU_P (cpu_features, BMI2)
- && CPU_FEATURES_CPU_P (cpu_features, LZCNT)
- && CPU_FEATURES_CPU_P (cpu_features, MOVBE)
- && CPU_FEATURES_CPU_P (cpu_features, POPCNT))
- platform = "haswell";
-
- if (platform != NULL)
- GLRO(dl_platform) = platform;
- }
-#else
- GLRO(dl_hwcap) = 0;
- if (CPU_FEATURES_CPU_P (cpu_features, SSE2))
- GLRO(dl_hwcap) |= HWCAP_X86_SSE2;
-
- if (CPU_FEATURES_ARCH_P (cpu_features, I686))
- GLRO(dl_platform) = "i686";
- else if (CPU_FEATURES_ARCH_P (cpu_features, I586))
- GLRO(dl_platform) = "i586";
-#endif
+ set_platform(cpu_features);
#if CET_ENABLED
# if HAVE_TUNABLES
--
2.20.1
next prev parent reply other threads:[~2020-03-16 6:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-16 6:44 [PATCH 0/3] RFC: Platform Support for AMD Zen and AVX2/AVX Prem Mallappa
2020-03-16 6:44 ` Prem Mallappa [this message]
2020-03-16 6:44 ` [PATCH 2/3] x86: Add AMD Zen and AVX2/AVX platform support Prem Mallappa
2020-03-16 6:44 ` [PATCH 3/3] x86: test to load from PLATFORM path Prem Mallappa
2020-03-16 20:39 ` [PATCH 0/3] RFC: Platform Support for AMD Zen and AVX2/AVX Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316064408.13808-2-PMallappa@amd.com \
--to=prem.mallappa@gmail.com \
--cc=FWeimer@redhat.com \
--cc=Premachandra.Mallappa@amd.com \
--cc=codonell@redhat.com \
--cc=libc-help@sourceware.org \
--cc=schwab@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).