From: Florian Weimer <fweimer@redhat.com>
To: "Hongzhi, Song" <hongzhi.song@windriver.com>, libc-help@sourceware.org
Subject: Re: Question about sysdeps/unix/sysv/linux/fcntl.c
Date: Thu, 13 Sep 2018 15:55:00 -0000 [thread overview]
Message-ID: <2577c6ad-960e-29ca-99db-b59a8d0c78bc@redhat.com> (raw)
In-Reply-To: <455c36bd-8c00-6228-359b-7c6820e69e6e@windriver.com>
On 09/13/2018 03:57 PM, Hongzhi, Song wrote:
> Hi all,
>
> I have a issue on ltp relevant glibc.
>
> https://github.com/linux-test-project/ltp/issues/395
>
>
> Could someone tell how to fix it?
See the other thread. I submitted a reply on Github us well:
`fcntl` always uses `struct flock` arguments. If you use `struct
flock64`, you should be using `fcntl64`. The issue also goes away if you
build with `-D_FILE_OFFSET_BITS=64` because then `struct flock` and
`struct flock64` are basically identical.
The reason for the change was that there is no 32-bit version of the OFD
locks and no separate `F_OFD_SETLKW` constant, and that `fcntl`
defaulting to 64-bit in 32-bit mode was just too confusing. The
previous/non-OFD locks did not do that.
Thanks,
Florian
prev parent reply other threads:[~2018-09-13 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-13 13:54 Hongzhi, Song
2018-09-13 15:55 ` Florian Weimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2577c6ad-960e-29ca-99db-b59a8d0c78bc@redhat.com \
--to=fweimer@redhat.com \
--cc=hongzhi.song@windriver.com \
--cc=libc-help@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).