public inbox for libc-help@sourceware.org
 help / color / mirror / Atom feed
From: Gibeom Gwon <gb.gwon@stackframe.dev>
To: libc-help@sourceware.org
Subject: Handles the masked signal when the thread exits
Date: Fri, 19 Nov 2021 03:07:25 +0900	[thread overview]
Message-ID: <2fb82128-a9da-e7f5-8062-f7e72b1561db@stackframe.dev> (raw)

Hello,

I am experiencing strange(unintended?) behavior when using pthread with 
signals. If I set the signal mask with pthread_sigmask() in the thread 
function and the process has pending signal when thread is exiting, 
signal handler executed in thread.

It looks like glibc restores original signal mask at the end of the 
thread. So I suspect this eventually triggers masked signal handler. But 
I'm not sure it is intended or not.

Code samples:

sleep.c
-------
#include <stdio.h>
#include <stdlib.h>
#include <unistd.h>
#include <signal.h>
#include <sys/wait.h>
#include <pthread.h>

pthread_t thread;
pid_t pid;

void stop_threads() {
		pthread_cancel(thread);
		pthread_join(thread, NULL);
}

void sigint_handler(int signum) {
	printf("sigint: %ld\n",pthread_self());
	stop_threads();
	exit(0);
}

void sigchld_handler(int signum) {
	printf("sigchld: %ld\n",pthread_self());
	pid_t pid;
	int status;
	while((pid = waitpid(-1,&status,WNOHANG)) > 0) {}
}

void spawn_sleep() {
	pid = fork();
	if(pid == 0)
		execl("./sleep","sleep",NULL);
}

void* worker(void *arg) {
	sigset_t mask;
	sigfillset(&mask);
	pthread_sigmask(SIG_SETMASK,&mask,NULL);

	pthread_setcancelstate(PTHREAD_CANCEL_DISABLE,NULL);
	int i = 10;
	while(i) {
		printf("worker...\n");
		sleep(1);
		i--;
	}
	pthread_setcancelstate(PTHREAD_CANCEL_ENABLE,NULL);
     	printf("thread close\n");
	pthread_exit(0);
}

void spawn_thread() {
     pthread_create(&thread,NULL,worker,NULL);
     printf("child thread: %ld\n",thread);
}

int main() {
	printf("main thread: %ld\n",pthread_self());
	spawn_sleep();	

	struct sigaction sa1;
	sa1.sa_handler = sigint_handler;
	sigemptyset(&sa1.sa_mask);
	sigaddset(&sa1.sa_mask,SIGCHLD);
	sa1.sa_flags = 0;
	sigaction(SIGINT, &sa1, 0);

	struct sigaction sa2;
	sa2.sa_handler = sigchld_handler;
	sigemptyset(&sa2.sa_mask);
	sa2.sa_flags = 0;
	sigaction(SIGCHLD, &sa2, 0);

	spawn_thread();

	while(1)
		sleep(1);

	return 0;
}


result
======
$ ./signal
main thread: 139882152073024
child thread: 139882152068672
worker...
worker...
worker...
^Csigint: 139882152073024
worker...
worker...
worker...
worker...
worker...
worker...
worker...
thread close
sigchld: 139882152068672

Comprehensive signal mask set in worker() but SIGCHLD handler executed 
after thread function exited.

Regards,
Gibeom Gwon

             reply	other threads:[~2021-11-18 18:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-18 18:07 Gibeom Gwon [this message]
2021-11-18 18:08 ` Florian Weimer
2021-11-18 18:11   ` Gibeom Gwon
2021-11-18 18:19     ` Florian Weimer
2021-11-18 18:25       ` Gibeom Gwon
2021-11-18 18:31         ` Florian Weimer
2021-11-18 18:35           ` Gibeom Gwon
2021-11-18 19:10             ` Florian Weimer
2021-11-18 19:29               ` Gibeom Gwon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2fb82128-a9da-e7f5-8062-f7e72b1561db@stackframe.dev \
    --to=gb.gwon@stackframe.dev \
    --cc=libc-help@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).