From: Siddhesh Poyarekar <siddhesh@gotplt.org>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: brunni@netestate.de, cottrell@wfu.edu, libc-help@sourceware.org,
GLIBC Devel <libc-alpha@sourceware.org>
Subject: Re: my strstr is broken
Date: Tue, 11 Sep 2018 15:38:00 -0000 [thread overview]
Message-ID: <3c756a0e-8b34-3f9f-df03-4dd308442484@gotplt.org> (raw)
In-Reply-To: <CALoOobMRm+OgtuRjOzPCOJFYqNMG1AnMeRXoqcOp8Vc_D_jRmQ@mail.gmail.com>
On Tuesday 11 September 2018 08:51 PM, Paul Pluzhnikov wrote:
> This is the second time in my (short) memory strstr got broken with
> very long inputs
> (https://sourceware.org/bugzilla/show_bug.cgi?id=12092).
> There was also https://sourceware.org/bugzilla/show_bug.cgi?id=14602
>
> It seems that testing of strstr is entirely inadequate: (AFAICT) we
> only test the IFUNC-selected version, and only on small set of inputs.
I'm not sure about the assertion about not testing IFUNC versions (since
only x86_64 and powerpc seem to be using them and their IFUNC_IMPL
macros look correct to me and should trigger all variants provided the
hardware supports it) but a stress test would be most welcome.
Thanks,
Siddhesh
next prev parent reply other threads:[~2018-09-11 15:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 14:47 Michael Brunnbauer
2018-09-11 10:27 ` Michael Brunnbauer
2018-09-11 12:58 ` Allin Cottrell
2018-09-11 13:54 ` Michael Brunnbauer
2018-09-11 14:21 ` Siddhesh Poyarekar
2018-09-11 14:41 ` Michael Brunnbauer
2018-09-11 14:51 ` Siddhesh Poyarekar
2018-09-11 15:21 ` Paul Pluzhnikov via libc-help
2018-09-11 15:38 ` Siddhesh Poyarekar [this message]
2018-09-11 18:46 Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c756a0e-8b34-3f9f-df03-4dd308442484@gotplt.org \
--to=siddhesh@gotplt.org \
--cc=brunni@netestate.de \
--cc=cottrell@wfu.edu \
--cc=libc-alpha@sourceware.org \
--cc=libc-help@sourceware.org \
--cc=ppluzhnikov@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).