From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 67536 invoked by alias); 11 Sep 2018 15:38:32 -0000 Mailing-List: contact libc-help-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: libc-help-owner@sourceware.org Received: (qmail 67510 invoked by uid 89); 11 Sep 2018 15:38:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.2 spammy=tuesday, Tuesday, Hx-languages-length:744 X-HELO: homiemail-a145.g.dreamhost.com Received: from sub5.mail.dreamhost.com (HELO homiemail-a145.g.dreamhost.com) (208.113.200.129) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 15:38:30 +0000 Received: from homiemail-a145.g.dreamhost.com (localhost [127.0.0.1]) by homiemail-a145.g.dreamhost.com (Postfix) with ESMTP id 095ED60001330; Tue, 11 Sep 2018 08:38:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=gotplt.org; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=gotplt.org; bh=LuFK/x obmF8wzsWhIUa3WgDrAkI=; b=R/qcjPtIb4OfalLHnBGF2Ng3HgRcT6nnr5A4C+ 6/LIvhqfKRU7FmRjAcspb0bd88c45GdZk9oePd72UITTW81axZIV9afcv5dQbhJp 043SHgCfwx9+5s+30q+Y2xKZ/Qf0LPMZQd6ra36b3HslbPWL6qjX+KMn8zjBQtzH UNC7E= Received: from [192.168.0.48] (unknown [202.189.238.75]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by homiemail-a145.g.dreamhost.com (Postfix) with ESMTPSA id 2A7656000131A; Tue, 11 Sep 2018 08:38:26 -0700 (PDT) Subject: Re: my strstr is broken To: Paul Pluzhnikov Cc: brunni@netestate.de, cottrell@wfu.edu, libc-help@sourceware.org, GLIBC Devel References: <20180910144752.GA29636@netestate.de> <20180911102711.GA31876@netestate.de> <20180911135401.GA1745@netestate.de> <20180911144138.GA2030@netestate.de> From: Siddhesh Poyarekar Message-ID: <3c756a0e-8b34-3f9f-df03-4dd308442484@gotplt.org> Date: Tue, 11 Sep 2018 15:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2018-09/txt/msg00008.txt.bz2 On Tuesday 11 September 2018 08:51 PM, Paul Pluzhnikov wrote: > This is the second time in my (short) memory strstr got broken with > very long inputs > (https://sourceware.org/bugzilla/show_bug.cgi?id=12092). > There was also https://sourceware.org/bugzilla/show_bug.cgi?id=14602 > > It seems that testing of strstr is entirely inadequate: (AFAICT) we > only test the IFUNC-selected version, and only on small set of inputs. I'm not sure about the assertion about not testing IFUNC versions (since only x86_64 and powerpc seem to be using them and their IFUNC_IMPL macros look correct to me and should trigger all variants provided the hardware supports it) but a stress test would be most welcome. Thanks, Siddhesh