From: "Stefan Kanthak" <stefan.kanthak@nexgo.de>
To: <libc-help@sourceware.org>
Subject: Twiddling with 64-bit values as 2 ints;
Date: Sat, 21 Aug 2021 15:34:50 +0200 [thread overview]
Message-ID: <4DD65B114A174A35AC6960DD2104BDE7@H270> (raw)
Hi,
32 years ago, C89 introduced 64-bit integers: [un]signed long long
IEEE 754 defined the 64-bit double-precision floating-point format,
now called binary64. in 1985.
Especially SunSoft's [fd]libm, which (to my knowledge) started around
this time, and also IBM's APMathLib/libultim, which followed a little
later, and also quite some ACM TOMS routines, but use (pairs of) 32-bit
integers for bit-twiddling on the representation of double/binary64:
additions/subtractions/shifts on the 52-bit mantissa/fraction, and
operations on the full 64-bit double, involve both ints, and need to
take care of the carry/borrow -- explicitly, and quite ugly!
It's also generally unknown whether a compiler will recognize this
sort of carry/borrow/overflow handling and generate proper machine
code using "add with carry"/"subtract with borrow" instructions.
JFTR: while sticking with 32-bit integers MAY give better performance
on 32-bit processors, especially when an operations only involves
either low or high part, the explicit carry/borrow handling can
have negative performance impact.
See for example <http://www.netlib.no/netlib/toms/722>, written by
William J. Cody (known from Cody/Waite range reduction):
| W. J. Cody, J. T. Coonen, March 30, 1992
...
| /* Otherwise, use integer arithmetic to increment or */
| /* decrement least significant half of z, being careful */
| /* with carries and borrows involving most significant */
| /* half. */
| else if (((argx < Zero) && (argx < argy)) ||
| ((argx > Zero) && (argx > argy))) {
| --lowpart(z);
| if (lowpart(z) == -1)
| --highpart(z);
| }
| else {
| ++lowpart(z);
| if (lowpart(z) == 0)
| ++highpart(z);
| }
|
Compare this with the REALLY UGLY
<https://sourceware.org/git/?p=glibc.git;a=blob_plain;f=math/s_nextafter.c;hb=HEAD>
| * Copyright (C) 1993 by Sun Microsystems, Inc. All rights reserved.
...
| if(((ix>=0x7ff00000)&&((ix-0x7ff00000)|lx)!=0) || /* x is nan */
| ((iy>=0x7ff00000)&&((iy-0x7ff00000)|ly)!=0)) /* y is nan */
| return x+y;
...
| if(hx>=0) { /* x > 0 */
| if(hx>hy||((hx==hy)&&(lx>ly))) { /* x > y, x -= ulp */
| if(lx==0) hx -= 1;
| lx -= 1;
| } else { /* x < y, x += ulp */
| lx += 1;
| if(lx==0) hx += 1;
| }
| } else { /* x < 0 */
| if(hy>=0||hx>hy||((hx==hy)&&(lx>ly))){/* x < y, x -= ulp */
| if(lx==0) hx -= 1;
| lx -= 1;
| } else { /* x > y, x += ulp */
| lx += 1;
| if(lx==0) hx += 1;
| }
| }
(Heretic.-) questions:
- why does glibc still employ such ugly code?
- Why doesn't glibc take advantage of 64-bit integers in such code?
JFTR: on 64-bit processors, when the compiler does not recognize
that hx:lx and hy:ly are in fact a single 64-bit integer it
can hold in a SINGLE register, but smears it over 2 registers,
such cruft kills performance.
For 32-bit processors, the JFTR from above still holds: using 64-bit
integers with a C89 compiler should give better machine code.
Stefan
next reply other threads:[~2021-08-21 13:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 13:34 Stefan Kanthak [this message]
2021-08-23 12:23 ` Adhemerval Zanella
2021-08-23 13:18 ` Stefan Kanthak
2021-08-23 14:11 ` Adhemerval Zanella
2021-08-23 15:37 ` Stefan Kanthak
2021-08-23 16:51 ` Adhemerval Zanella
2021-08-23 17:32 ` Stefan Kanthak
2021-08-23 18:24 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DD65B114A174A35AC6960DD2104BDE7@H270 \
--to=stefan.kanthak@nexgo.de \
--cc=libc-help@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).