public inbox for libc-help@sourceware.org
 help / color / mirror / Atom feed
From: Florian Weimer <fweimer@redhat.com>
To: Paul Wise <pabs3@bonedaddy.net>
Cc: Libc-help <libc-help@sourceware.org>
Subject: Re: is this a bug in glibc or readpst?
Date: Mon, 07 Aug 2023 13:46:03 +0200	[thread overview]
Message-ID: <87edkfgjno.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <161b0b6563925702c3fda431ae703d0aa395b60a.camel@bonedaddy.net> (Paul Wise's message of "Mon, 07 Aug 2023 19:00:47 +0800")

* Paul Wise:

> On Mon, 2023-08-07 at 10:59 +0200, Florian Weimer wrote:
>
>> We could perhaps avoid the seek for read-only streams.  We are about to
>> close the stream anyway, so fflush does not have any useful effect
>> anyway.  Not sure what others think if it is worth the complexity.  On
>> the other hand, preserving backwards compatibility here does not appear
>> to be too onerous.
>
> It might be worth checking what other implementations do, perhaps
> if they all avoid the seek in this case then maybe glibc should too?

I expect this is difficult to figure out for certain because of the
internal stream state may not be very clear unless you are familiar with
the code. 8-(

So I'd prefer to fix the glibc regression instead.

Thanks,
Florian


  reply	other threads:[~2023-08-07 11:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  2:02 Paul Wise
2022-11-23  8:57 ` Florian Weimer
2022-11-24  0:06   ` Paul Wise
2022-12-02 17:37     ` Florian Weimer
2023-08-06  6:07       ` Paul Wise
2023-08-07  8:59         ` Florian Weimer
2023-08-07 11:00           ` Paul Wise
2023-08-07 11:46             ` Florian Weimer [this message]
2023-08-07 11:58               ` Paul Wise

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87edkfgjno.fsf@oldenburg.str.redhat.com \
    --to=fweimer@redhat.com \
    --cc=libc-help@sourceware.org \
    --cc=pabs3@bonedaddy.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).