From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 88C133858281 for ; Mon, 20 Jun 2022 07:31:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 88C133858281 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-614-n87U8qBYPBq8JzpYXnzwag-1; Mon, 20 Jun 2022 03:31:26 -0400 X-MC-Unique: n87U8qBYPBq8JzpYXnzwag-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 6F574101AA45; Mon, 20 Jun 2022 07:31:26 +0000 (UTC) Received: from oldenburg.str.redhat.com (unknown [10.39.193.54]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 87D77492CA3; Mon, 20 Jun 2022 07:31:25 +0000 (UTC) From: Florian Weimer To: Reddy K via Libc-help Cc: Reddy K Subject: Re: Regarding FD_ZERO compilation warning References: Date: Mon, 20 Jun 2022 09:31:23 +0200 In-Reply-To: (Reddy K. via Libc-help's message of "Mon, 20 Jun 2022 09:17:17 +0530") Message-ID: <87edzjn644.fsf@oldenburg.str.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.85 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-help@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-help mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2022 07:31:29 -0000 * Reddy K. via Libc-help: > I have enabled all compilation flags and did "make" build. I got the > warning below and have tried to include required header files ( select.h, > time.h, types.h and unistd.h) but still it shows the warning. So can you > please help me to fix this. > > ds_locator.c:930:2: warning: traditional C rejects string constant > concatenation [-Wtraditional] > FD_ZERO(&readfds); > > I am pasting the code snippet below to understand how variable readfds > define. > ----------------------------- > fd_set readfds; > FD_ZERO(&readfds); > > ---------------------------- I don't see how glibc's FD_ZERO can trigger this compiler warning. I suggest you generate preprocessed sources with gcc --save-temps or gcc -E, and show us the macro expansion. In general, there is no expectation that the glibc headers are clean with -Wtraditional, quite the opposite actually. We require an ISO C compiler. Thanks, Florian