public inbox for libc-help@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: "Konstantin Kharlamov" <Hi-Angel@yandex.ru>,
	"Lukáš Jiřiště" <gymnazium.jiriste@gmail.com>,
	libc-help@sourceware.org
Subject: Re: Where to send issues
Date: Wed, 24 Jan 2024 08:44:29 -0500	[thread overview]
Message-ID: <882e2cdb-fce8-c514-2af0-38a86cdc7526@redhat.com> (raw)
In-Reply-To: <e761c1ad17afa2eb5cee245a0fd8e4bab2637d4f.camel@yandex.ru>

On 1/24/24 03:19, Konstantin Kharlamov wrote:
> On Wed, 2024-01-24 at 11:15 +0300, Konstantin Kharlamov wrote:
>> On Wed, 2024-01-24 at 09:05 +0100, Lukáš Jiřiště via Libc-help wrote:
>>> Hello everyone,
>>> this is exciting as this is my first time ever using mailing list.
>>> I'm writing this, because I wanted to know, where to submit a minor
>>> typo in
>>> the GNU libc manual or whether there's a way I can fix it myself.
>>> Thank you all in advance. Have a nice day.
>>
>> You can fix it yourself and send to a libc-alpha@sourceware.org ML.
>> But
>> Glibc is very tough to contribute to because of lack of reviews for
>> patches, so patches often just hang in there for years. I've seen it
>> both from the side (you often see people ping over and over) and I
>> have
>> myself a series of small fixes from 2019 or something that I was
>> pinging but to my knowledge by this day nobody reviewed it.
> 
> Ah, and you also need to sign some documents to be able to contribute
> to glibc 😂 FTR, I have signed it, it's just an oddness that GNU
> projects have. So, yeah, there's that as well 😄

Today the project accepts contributions without copyright assignment.

https://sourceware.org/glibc/wiki/Contribution%20checklist

You can just use DCO e.g. "Signed-off-by:" if you can attest to the Developer
Certificate of Origin as Linux kernel developers do.

>> So unless you are motivated to ping over and over, I'd advice just
>> fill
>> a bugreport. You can do that here
>> https://sourceware.org/bugzilla/enter_bug.cgi, chose "libc" as a
>> product.

I'm sorry to hear that you had a bad experience trying to contribute :-(

It is indeed a problem that FOSS projects lack sufficient maintainer resources
to review incoming patches.

We try to help out with that by having a weekly Monday morning patch queue review.

https://sourceware.org/glibc/wiki/PatchworkReviewMeetings

The intent of the meetings is to allow the community to attend and raise patches
they would like reviewed.

We track 2 metrics for the patch queue:
- How many currently need to be reviewed e.g. State NEW delegate NOBODY.
- How many days on average the patches have been in the queue.

The latter metric is at ~260 days, which is a number I watch to see what we
can do e.g. spend a week reviewing patches or not.

We are trying to use pre-commit CI to make it easier to commit simpler patches.
https://patchwork.sourceware.org/project/glibc/list/

I see patches from you in 2019 which predate our start of the patch queue review
and the pre-commit CI work. Please feel free to repost them if they still apply
and we'll see if we can get them committed.

-- 
Cheers,
Carlos.


  reply	other threads:[~2024-01-24 13:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-24  8:05 Lukáš Jiřiště
2024-01-24  8:15 ` Konstantin Kharlamov
2024-01-24  8:19   ` Konstantin Kharlamov
2024-01-24 13:44     ` Carlos O'Donell [this message]
2024-01-24 13:46       ` Konstantin Kharlamov
2024-01-24 10:03 ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=882e2cdb-fce8-c514-2af0-38a86cdc7526@redhat.com \
    --to=carlos@redhat.com \
    --cc=Hi-Angel@yandex.ru \
    --cc=gymnazium.jiriste@gmail.com \
    --cc=libc-help@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).