From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2741 invoked by alias); 27 Sep 2017 05:54:04 -0000 Mailing-List: contact libc-help-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: libc-help-owner@sourceware.org Received: (qmail 824 invoked by uid 89); 27 Sep 2017 05:54:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM autolearn=ham version=3.3.2 spammy=Hx-languages-length:2149 X-HELO: mail-qt0-f170.google.com Received: from mail-qt0-f170.google.com (HELO mail-qt0-f170.google.com) (209.85.216.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 27 Sep 2017 05:54:00 +0000 Received: by mail-qt0-f170.google.com with SMTP id q4so12583413qtq.8 for ; Tue, 26 Sep 2017 22:54:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=jg4Y+rQGIg9MqbKVUgxEq/x5sVGt8NkaR+c0Wqaozmk=; b=V+A6ocGGKT4UKVjIewwewMbK8urBuYT9eQ7s7fpUYRuYk0e2nMJjLy4g1HaWqV3xFm oFsINFlGxEM6KOCEqCgRDYxJ8MIYryKoDLpIAqhsGcNZIS4jKaDHLkAF/MmMFOgrgrfj NHsNvu0XYhj1OHUJb0R0UiDo8KnH/ARLYPQyG14pmBwi8RjlO3IbPJSOtXfUhwG8Z4ab QMFBgo0FuBjiZH17o4GCYGDqWM94H+6hfDdwLQr+TMS9OPvOqdiI6FbBWeZCHAuftVG9 aW9PMUuF0fHjj8VZu1hLe5evGzQpXcQShhmQY/ZexeYeUVJa2nw0jB/Yi4rdmyMOHiI+ UfnA== X-Gm-Message-State: AHPjjUgssXf2doXEum1OA5mtcXBCuxUsc5wkEBl9WXsbbaLOPEgqa513 x52GPcobN8METXUjLTKIityHLQ== X-Google-Smtp-Source: AOwi7QAHdCd7PDMZEQU16FbB1nemBSjdaEI/poZQTyWRVCJuYao1VnAAr8jbYsNTW8IAMtSY46vtzQ== X-Received: by 10.200.47.16 with SMTP id j16mr350477qta.161.1506491639181; Tue, 26 Sep 2017 22:53:59 -0700 (PDT) Received: from [192.168.222.10] ([184.151.222.97]) by smtp.gmail.com with ESMTPSA id x62sm8735668qkg.39.2017.09.26.22.53.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Sep 2017 22:53:58 -0700 (PDT) Subject: Re: Understanding why getaddrinfo_a and __gai_enqueue_request use recursive locks To: Will Hawkins Cc: libc-help@sourceware.org, Will Hawkins References: From: Carlos O'Donell Message-ID: <9f81ae62-63a0-d377-fcdc-cde6f4cfc520@redhat.com> Date: Wed, 27 Sep 2017 05:54:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00041.txt.bz2 On 09/26/2017 12:39 PM, Will Hawkins wrote: > On Tue, Sep 26, 2017 at 2:06 AM, Will Hawkins wrote: >> On Tue, Sep 26, 2017 at 12:42 AM, Carlos O'Donell wrote: >>> Can you test removing them and ga_test.c? >>> >>> diff --git a/resolv/Makefile b/resolv/Makefile >>> index ec7e4fd..8a822e0 100644 >>> --- a/resolv/Makefile >>> +++ b/resolv/Makefile >>> @@ -101,10 +101,6 @@ routines += $(libnss_dns-routines) $(libresolv-routines) >>> static-only-routines += $(libnss_dns-routines) $(libresolv-routines) >>> endif >>> >>> -ifeq (yesyes,$(build-shared)$(have-thread-library)) >>> -tests: $(objpfx)ga_test >>> -endif >>> - >>> ifeq ($(run-built-tests),yes) >>> ifneq (no,$(PERL)) >>> tests-special += $(objpfx)mtrace-tst-leaks.out >>> @@ -134,8 +130,6 @@ $(objpfx)libnss_dns.so: $(objpfx)libresolv.so >>> # The asynchronous name lookup code needs the thread library. >>> $(objpfx)libanl.so: $(shared-thread-library) >>> >>> -$(objpfx)ga_test: $(objpfx)libanl.so $(shared-thread-library) >>> - >>> $(objpfx)tst-res_hconf_reorder: $(libdl) $(shared-thread-library) >>> tst-res_hconf_reorder-ENV = RESOLV_REORDER=on >>> >>> --- >>> >> >> I am testing this as we speak but don't think that I will know the >> answer before I head to sleep tonight. I will respond as soon as my >> tests have completed their execution. > > Testing of this 'patch' is complete. I applied the change then used > the instructions on > https://sourceware.org/glibc/wiki/Testing/Testsuite#Testing_just_one_test > to test. Here's how I did it: > > From the build directory, I did > rm -f resolv/*.out > make subdirs=resolv check > > and everything ran the way I expected (the same number of test > failures and passes). > > Thanks again for all your help! Awesome, thanks. I'll see about posting a patch to do that, and include you in the testing notes. Alternatively you can post the patch yourself and I'll approve it, the changes are mechanical and below the copyright limit, but any future work would require copyright assignment :-) -- Cheers, Carlos.