From: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
To: brunni@netestate.de
Cc: cottrell@wfu.edu, libc-help <libc-help@sourceware.org>
Subject: Re: my strstr is broken
Date: Tue, 11 Sep 2018 14:51:00 -0000 [thread overview]
Message-ID: <CAAHN_R1PBjz=+NsoA=XCdKcWCi+A-BaG=f29tM9aqyp7+CC_Aw@mail.gmail.com> (raw)
In-Reply-To: <20180911144138.GA2030@netestate.de>
On Tue, 11 Sep 2018 at 20:11, Michael Brunnbauer <brunni@netestate.de> wrote:
> No it's i686-pc-linux-gnu (output from gcc -dumpmachine).
>
> arch reports x86_64 because the kernel is 64 bit but everything else is 32 bit.
>
> > I can reproduce this on the glibc
> > 2.28 tag when I hack the ifunc resolver to ignore
> > __strstr_sse2_unaligned and always use the stock __strstr.
>
> So the stock __strstr has a bug?
>
> A 32 bit glibc would not use __strstr_sse2_unaligned, right?
Right, my question should have been 'non-x86_64' I flew back ~5 time
zones this morning and my brain's still a bit mushy, sorry :)
The stock __strstr has a bug, which seems to have been fixed on master
with the commit I mentioned. I'll need to vet it to make sure that
the fix is not just incidental and that the root cause (which I
haven't understood yet, jet lag, etc.) is also fixed and then backport
it to the 2.28 branch.
Siddhesh
--
http://siddhesh.in
next prev parent reply other threads:[~2018-09-11 14:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 14:47 Michael Brunnbauer
2018-09-11 10:27 ` Michael Brunnbauer
2018-09-11 12:58 ` Allin Cottrell
2018-09-11 13:54 ` Michael Brunnbauer
2018-09-11 14:21 ` Siddhesh Poyarekar
2018-09-11 14:41 ` Michael Brunnbauer
2018-09-11 14:51 ` Siddhesh Poyarekar [this message]
2018-09-11 15:21 ` Paul Pluzhnikov via libc-help
2018-09-11 15:38 ` Siddhesh Poyarekar
2018-09-11 18:46 Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAHN_R1PBjz=+NsoA=XCdKcWCi+A-BaG=f29tM9aqyp7+CC_Aw@mail.gmail.com' \
--to=siddhesh.poyarekar@gmail.com \
--cc=brunni@netestate.de \
--cc=cottrell@wfu.edu \
--cc=libc-help@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).