From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129388 invoked by alias); 11 Sep 2018 14:51:22 -0000 Mailing-List: contact libc-help-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: libc-help-owner@sourceware.org Received: (qmail 129374 invoked by uid 89); 11 Sep 2018 14:51:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:968, incidental, morning, H*Ad:D*edu X-HELO: mail-oi0-f67.google.com Received: from mail-oi0-f67.google.com (HELO mail-oi0-f67.google.com) (209.85.218.67) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 14:51:20 +0000 Received: by mail-oi0-f67.google.com with SMTP id k12-v6so47656772oiw.8 for ; Tue, 11 Sep 2018 07:51:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qL60DlQebr9LGbK4KeYRX/JyX7qNwKtcsHBHz4HctdY=; b=QE5SnzDtW6Ap6ZZq8GxNKYXinfJU68dQVZvhYytAWHiZZpGgO3PL6XHlbKej0rhjKW VooBkvo25TOt+PHPFCUNCwwGb5WWn4Yp3GTPNIZixXhc1Q8FovtZqyUiiaabNGUtYgYF +2M6TPsGMLQyxMrLfRzxBqpTDl25/bwiJS1MfRYfAgYAEM+qItbl2/Y6BqULBJXrfKK8 5TM8xgFXxyAqI8gcITLRfKUhCDxKfjJ5jjKCYCDZ2eb6cOsyC67IAoNfWPUcBZGW+OmP 53JIcInwrQqarWqXxFg5/O5j8ySdMVUZhXBvobvmmBWDfN9hfjatoMJI+hpX+Mk2tOWX ZQUA== MIME-Version: 1.0 References: <20180910144752.GA29636@netestate.de> <20180911102711.GA31876@netestate.de> <20180911135401.GA1745@netestate.de> <20180911144138.GA2030@netestate.de> In-Reply-To: <20180911144138.GA2030@netestate.de> From: Siddhesh Poyarekar Date: Tue, 11 Sep 2018 14:51:00 -0000 Message-ID: Subject: Re: my strstr is broken To: brunni@netestate.de Cc: cottrell@wfu.edu, libc-help Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00006.txt.bz2 On Tue, 11 Sep 2018 at 20:11, Michael Brunnbauer wrote: > No it's i686-pc-linux-gnu (output from gcc -dumpmachine). > > arch reports x86_64 because the kernel is 64 bit but everything else is 32 bit. > > > I can reproduce this on the glibc > > 2.28 tag when I hack the ifunc resolver to ignore > > __strstr_sse2_unaligned and always use the stock __strstr. > > So the stock __strstr has a bug? > > A 32 bit glibc would not use __strstr_sse2_unaligned, right? Right, my question should have been 'non-x86_64' I flew back ~5 time zones this morning and my brain's still a bit mushy, sorry :) The stock __strstr has a bug, which seems to have been fixed on master with the commit I mentioned. I'll need to vet it to make sure that the fix is not just incidental and that the root cause (which I haven't understood yet, jet lag, etc.) is also fixed and then backport it to the 2.28 branch. Siddhesh -- http://siddhesh.in