From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by sourceware.org (Postfix) with ESMTPS id 711513858280 for ; Thu, 16 Jun 2022 05:13:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 711513858280 Received: by mail-pf1-x42b.google.com with SMTP id bo5so515193pfb.4 for ; Wed, 15 Jun 2022 22:13:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=k3D4v65auspfzkJ7tmdbeKdg8AoJsQfbCccxAM4hLF4=; b=b8bHnQdj+EffZSM0XmGXcv2o7Rd1p8mD4SlotP5kOWeLhxuEfOcG0LVW8kIMz/T+zn d68r6p1aUFJ0gEPe0By3szG4vVHz+RCpMKwSLbVJnq6qFM2CCFdgDrsj+xaDQxwXwWdq zbuXCW2NFABXuimxgb0a4tBLKTQm9DruiDAbslz+zyn5Yyhe6Wc7/C1sOsMvCu6/Mxby 8KtwgXR7a4tG2AL/GAMYTqY4UEKpWftvVxcLnxxARuhOkzyztberKzRe0EecFDOp+ikx Phr+XyV695lwln298jrjWk+J714Q6GcMTwQLp4frgYNhQ8OUfVf3Y220wN1V/exriVGE hn0A== X-Gm-Message-State: AJIora/bI9SN/Ft8kV96jOcSpvuBuBlT0AuP/jpNTdK0lKfordfnCYK9 K/FdA26e6IBj+nlA4wzP/+Y/nBbDNuY41kHod38J87bW3lqnX0+h/v0= X-Google-Smtp-Source: AGRyM1uFbixMgfzmKFO0hxH9dI0XLyb/l0vNrCiD4wqvqljj/rQT0IXQ22eTsRh6oAogPl9wty1JHHWoUbSd71wVE1Y= X-Received: by 2002:a65:5207:0:b0:3fb:c00f:f6e4 with SMTP id o7-20020a655207000000b003fbc00ff6e4mr2864890pgp.415.1655356404020; Wed, 15 Jun 2022 22:13:24 -0700 (PDT) MIME-Version: 1.0 References: <2323859E-CD57-4DB0-88EC-74901E407D35@linaro.org> <87o7yup1my.fsf@oldenburg.str.redhat.com> <4842386B-AB4B-4B08-BFEC-45B420868B55@linaro.org> In-Reply-To: <4842386B-AB4B-4B08-BFEC-45B420868B55@linaro.org> From: Letu Ren Date: Thu, 16 Jun 2022 13:13:11 +0800 Message-ID: Subject: Re: How to skip test when building glibc To: Adhemerval Zanella Cc: Florian Weimer , Letu Ren via Libc-help Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-help@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-help mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Jun 2022 05:13:28 -0000 On Thu, Jun 16, 2022 at 4:33 AM Adhemerval Zanella wrote: > > I think ideally we should either split the tests that are taking too much= time > or increase the minimum expected timeout (so TIMEOUT_FACTOR is not > really needed as a default option). Yes, I totally agree with you. I think I should only increase the timeout limit to those tests which are necessary. Setting TIMEOUTFACTOR of all tests to 300 is not a good idea. However I don't know how to do that. I haven't figured out where the timeout limit is set after looking through code and doc. Should I report those failures to glibc bug mailing list, because some of them aren't mentioned in release notes? > For the tests that haven=E2=80=99t failed due a TIMEOUT, which are the *.= out contents? stdlib/test-bz22786 is another failure due to a timeout issue, It's just my carelessness. So we have four failures left. Their *.out contents are listed below. # cat math/test-float-j0.out testing float (without inline functions) Failure: Test: j0_upward (0x2.67a2a4p+0) Result: is: 5.64343701e-08 0x1.e4c47ep-25 should be: 5.64344021e-08 0x1.e4c490p-25 difference: 3.19744232e-14 0x1.200000p-45 ulp : 9.0000 max.ulp : 8.0000 Maximal error of `j0_upward' is : 9 ulp accepted: 8 ulp Test suite completed: 348 test cases plus 344 tests for exception flags and 344 tests for errno executed. 2 errors occurred. # cat math/test-float32-j0.out testing _Float32 (without inline functions) Failure: Test: j0_upward (0x2.67a2a4p+0) Result: is: 5.64343701e-08 0x1.e4c47ep-25 should be: 5.64344021e-08 0x1.e4c490p-25 difference: 3.19744232e-14 0x1.200000p-45 ulp : 9.0000 max.ulp : 8.0000 Maximal error of `j0_upward' is : 9 ulp accepted: 8 ulp Test suite completed: 348 test cases plus 344 tests for exception flags and 344 tests for errno executed. 2 errors occurred. # cat stdlib/tst-strfrom.out Testing in locale: C strfromf: got NAN (3), expected -NAN (4) strfromf32: got NAN (3), expected -NAN (4) Testing in locale: en_US.ISO-8859-1 strfromf: got NAN (3), expected -NAN (4) strfromf32: got NAN (3), expected -NAN (4) Testing in locale: en_US.UTF-8 strfromf: got NAN (3), expected -NAN (4) strfromf32: got NAN (3), expected -NAN (4) # cat stdlib/tst-strfrom-locale.out Testing in locale: de_DE.UTF-8 strfromf: got NAN (3), expected -NAN (4) strfromf32: got NAN (3), expected -NAN (4) Testing in locale: tr_TR.ISO-8859-9 strfromf: got NAN (3), expected -NAN (4) strfromf32: got NAN (3), expected -NAN (4) Testing in locale: tr_TR.UTF-8 strfromf: got NAN (3), expected -NAN (4) strfromf32: got NAN (3), expected -NAN (4)