From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x102a.google.com (mail-pj1-x102a.google.com [IPv6:2607:f8b0:4864:20::102a]) by sourceware.org (Postfix) with ESMTPS id F3F8A382CB9D for ; Wed, 15 Jun 2022 11:48:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org F3F8A382CB9D Received: by mail-pj1-x102a.google.com with SMTP id o33-20020a17090a0a2400b001ea806e48c6so1798732pjo.1 for ; Wed, 15 Jun 2022 04:48:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=Wi/lFTNkv+pltztVHgJvyXo+6aqJsVGf1xqEbjzv/Eg=; b=gzF0hA2spO8a9OeElojaLpFvSiFw2nrubBLGJbVJQLpP6Q90DYcUdlkoX/bx0yALxi 1vG1trVNbXWOMQ/cGvO1pAdt+63KrJhv7Ncmac1WTt/jaxWBbCFEspL/GAlKKraULKA2 NrZ2T2MPF7oreit5BZJDtiUQnF5JRl2dzmcDRhwQ3aF0eZjDc0p+CKbej9UqYxhxnApD px5YWRS2SaHSFZz6VMmjLojMsACCYJe4+7ccHxLMfXMUHFZImDKEfTTMr8zn6lu7uQmf BTH5m9KnRXElAV0QBERo1pcukyPaGWVYtCXMLNzQlU0HbPhEFvAn65GyMePpyfmiNK79 T9CA== X-Gm-Message-State: AJIora9Y9oDYNXV/ZxyiXyt7MCIdRIQTaeqpMSlVfIkLrsjccetIJEDl 6MVyVlY+Dz+QDBy4nN3vP15OW0v1f5v99O/Ie7o= X-Google-Smtp-Source: AGRyM1uZ2jbzJRKkqZFkBx731qZpOKfuyMr91+ZBA2RQCjWdY/ouZi8BEQ25jdE9PXgOEViqeda8U7ydCmL6qYXTfhw= X-Received: by 2002:a17:902:8f8f:b0:167:7fa1:60e2 with SMTP id z15-20020a1709028f8f00b001677fa160e2mr8731290plo.121.1655293695871; Wed, 15 Jun 2022 04:48:15 -0700 (PDT) MIME-Version: 1.0 References: <2323859E-CD57-4DB0-88EC-74901E407D35@linaro.org> In-Reply-To: <2323859E-CD57-4DB0-88EC-74901E407D35@linaro.org> From: Letu Ren Date: Wed, 15 Jun 2022 19:48:16 +0800 Message-ID: Subject: Re: How to skip test when building glibc To: Adhemerval Zanella Cc: libc-help@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-0.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: libc-help@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-help mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2022 11:48:18 -0000 Hi, > It depends of what you are doing on your build script. The =E2=80=98make= =E2=80=99 rule does > not run unit unit test, so if you intend to just build glibc it should be= suffice. I'm currently trying to build glibc for ArchLinux RISC-V. My build script executes `make` then `make check`. "It is highly recommended to have check() as it helps to make sure software has been built correctly and works fine with its dependencies." according to ArchLinux wiki Creating packages. So I think I need to `make check`. > However, if you are trying to run the expected make and make check you > try to not run the tests itself with the extra =E2=80=98run-built-tests= =3Dno=E2=80=99 rule with > =E2=80=98make check=E2=80=99. As I'm new to libc, I'm not sure what `run-built-tests=3Dno` does exactly. I cannot find a wiki page which mentions this make variable. I found some mail archives about it. "If you look at some of the Makefiles in glibc, it conditionally includes/excludes some tests from being built based on the value of run-built-tests.". And according to glibc/Makeconfig, "Whether to run test programs built for the library's host system." I wonder what this variable does exactly and whether `make check run-built-tests=3Dno` can make sure glibc built by myself is able to work correctly. > Unfortunately, there is no way to avoid specific tests in a default 'make= check=E2=80=99 > and this is intentional: a failure really should represent an issue that = might be > investigated. > > We are trying to either get rid of flaky tests or improve them in a way t= o make > them report robust output, to avoid environment issues that might mislead > the runner. > > What kind of issue are you seeing in you environment? I encountered 16 test failures. 11 of them are due to timeouts. FAIL: nss/tst-nss-files-hosts-getent FAIL: nss/tst-nss-files-hosts-multi FAIL: string/test-memcpy FAIL: string/test-memcpy-large FAIL: string/test-mempcpy FAIL: stdio-common/tst-vfprintf-width-prec FAIL: stdio-common/tst-vfprintf-width-prec-mem FAIL: resolv/tst-resolv-res_init-multi FAIL: malloc/tst-malloc-too-large-malloc-hugetlb2 FAIL: nptl/tst-mutex10 FAIL: locale/tst-localedef-path-norm And Five of them are mentioned in release notes of glibc v2.35. So I think those failures are expected. FAIL: math/test-float-j0 FAIL: math/test-float32-j0 FAIL: stdlib/tst-strfrom FAIL: stdlib/tst-strfrom-locale FAIL: stdlib/test-bz22786 As far as I know, ArchLinux officially skips some tests using sed in Makefile. Just simply remove some tests. In my case, I cannot simply sed, because I cannot find test-float-j0, which is generated in runtime. I planned to execute `TIMEOUTFACTOR=3D300 make check` to make sure no timeout issue occurs. So the only problem is how to deal with five expected to fail tests. Could you please give me some advice?