From: "Paul Pluzhnikov via libc-help" <libc-help@sourceware.org>
To: Siddhesh Poyarekar <siddhesh.poyarekar@gmail.com>
Cc: brunni@netestate.de, cottrell@wfu.edu, libc-help@sourceware.org,
GLIBC Devel <libc-alpha@sourceware.org>
Subject: Re: my strstr is broken
Date: Tue, 11 Sep 2018 15:21:00 -0000 [thread overview]
Message-ID: <CALoOobMRm+OgtuRjOzPCOJFYqNMG1AnMeRXoqcOp8Vc_D_jRmQ@mail.gmail.com> (raw)
In-Reply-To: <CAAHN_R1PBjz=+NsoA=XCdKcWCi+A-BaG=f29tM9aqyp7+CC_Aw@mail.gmail.com>
+cc libc-alpha
On Tue, Sep 11, 2018 at 7:51 AM Siddhesh Poyarekar
<siddhesh.poyarekar@gmail.com> wrote:
> The stock __strstr has a bug, which seems to have been fixed on master
> with the commit I mentioned.
This is the second time in my (short) memory strstr got broken with
very long inputs
(https://sourceware.org/bugzilla/show_bug.cgi?id=12092).
There was also https://sourceware.org/bugzilla/show_bug.cgi?id=14602
It seems that testing of strstr is entirely inadequate: (AFAICT) we
only test the IFUNC-selected version, and only on small set of inputs.
I filed https://sourceware.org/bugzilla/show_bug.cgi?id=23631
--
Paul Pluzhnikov
next prev parent reply other threads:[~2018-09-11 15:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-10 14:47 Michael Brunnbauer
2018-09-11 10:27 ` Michael Brunnbauer
2018-09-11 12:58 ` Allin Cottrell
2018-09-11 13:54 ` Michael Brunnbauer
2018-09-11 14:21 ` Siddhesh Poyarekar
2018-09-11 14:41 ` Michael Brunnbauer
2018-09-11 14:51 ` Siddhesh Poyarekar
2018-09-11 15:21 ` Paul Pluzhnikov via libc-help [this message]
2018-09-11 15:38 ` Siddhesh Poyarekar
2018-09-11 18:46 Wilco Dijkstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALoOobMRm+OgtuRjOzPCOJFYqNMG1AnMeRXoqcOp8Vc_D_jRmQ@mail.gmail.com \
--to=libc-help@sourceware.org \
--cc=brunni@netestate.de \
--cc=cottrell@wfu.edu \
--cc=libc-alpha@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=siddhesh.poyarekar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).