From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 68108 invoked by alias); 11 Sep 2018 15:21:44 -0000 Mailing-List: contact libc-help-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: libc-help-owner@sourceware.org Received: (qmail 68083 invoked by uid 89); 11 Sep 2018 15:21:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-12.4 required=5.0 tests=AWL,BAYES_00,ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_PASS,USER_IN_DEF_SPF_WL autolearn=ham version=3.3.2 spammy=Hx-languages-length:670, H*Ad:D*edu X-HELO: mail-yb1-f174.google.com Received: from mail-yb1-f174.google.com (HELO mail-yb1-f174.google.com) (209.85.219.174) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Sep 2018 15:21:42 +0000 Received: by mail-yb1-f174.google.com with SMTP id v10-v6so1793181ybm.8 for ; Tue, 11 Sep 2018 08:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=12J2zF6pkMRtU7LgsJhfvXdt2z5G6vmp87jP2PRXjrE=; b=AWcZ/O2L8TB+YjCLFd1J6INFC6VX3igxsdj6MbOBdL0JUDjRHXQDoAiXQm7BK4Nv96 GLeuCn2Zq5Oc8VOx2E2VKMz0gO2H8/mk+t1q6fgWAD7UwtnZpsjhOuic/c4hq/ZGwjVd UIBZh/9fqLxBHdHSaL8iXp1wp3GwuqZT/xt0+soAku/lrrSMCqs+hlknaFzSHuTmsLx4 wxa9urmMo3bVe/7o+BFa/iOKu6FL+R9HWGguhWW9TPxLxJDSzebT83djClp2vvcgL3CP x0VZ74Xijpgso28Wmo/1vpoGOVuiL6sXfUzg6sNZWxRNfrbiQhGmhPqpDVTqIdrGFONt nxqg== MIME-Version: 1.0 References: <20180910144752.GA29636@netestate.de> <20180911102711.GA31876@netestate.de> <20180911135401.GA1745@netestate.de> <20180911144138.GA2030@netestate.de> In-Reply-To: From: "Paul Pluzhnikov via libc-help" Reply-To: Paul Pluzhnikov Date: Tue, 11 Sep 2018 15:21:00 -0000 Message-ID: Subject: Re: my strstr is broken To: Siddhesh Poyarekar Cc: brunni@netestate.de, cottrell@wfu.edu, libc-help@sourceware.org, GLIBC Devel Content-Type: text/plain; charset="UTF-8" X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00007.txt.bz2 +cc libc-alpha On Tue, Sep 11, 2018 at 7:51 AM Siddhesh Poyarekar wrote: > The stock __strstr has a bug, which seems to have been fixed on master > with the commit I mentioned. This is the second time in my (short) memory strstr got broken with very long inputs (https://sourceware.org/bugzilla/show_bug.cgi?id=12092). There was also https://sourceware.org/bugzilla/show_bug.cgi?id=14602 It seems that testing of strstr is entirely inadequate: (AFAICT) we only test the IFUNC-selected version, and only on small set of inputs. I filed https://sourceware.org/bugzilla/show_bug.cgi?id=23631 -- Paul Pluzhnikov