From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119376 invoked by alias); 13 Dec 2019 16:58:37 -0000 Mailing-List: contact libc-help-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: libc-help-owner@sourceware.org Received: (qmail 119361 invoked by uid 89); 13 Dec 2019 16:58:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Received:4c9, 5.4.0, H*r:sk:libc-he, Director X-HELO: mail-oi1-f196.google.com Received: from mail-oi1-f196.google.com (HELO mail-oi1-f196.google.com) (209.85.167.196) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 13 Dec 2019 16:58:34 +0000 Received: by mail-oi1-f196.google.com with SMTP id l136so1448033oig.1 for ; Fri, 13 Dec 2019 08:58:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=X5Eg8PbpIjE42WFOm3Oy2YAjV6nneFGFrpPHUUhx5zQ=; b=M1ZkyY3y/pkLg6QwTgDHlHucFwchWd3PQmi9P3ZLbAEUL7lB4VlMWFaLa9j+JDFPqE ZCVa3CPJrrNU/ZbDmSyXX8cpn7iJjXt+xxK/ieqKsKxW1Y0OCg66ikH/EqwOeK41XdHn 8HmpqjvJCnyqxv3XXGsxSurfO/3ZK/iX7+WMRLpdl3AvmGtealKIzqtmafDelTYHzegC jm/9bB87nHRjBw5ungZwtlEtzssYYjsdmIMmT//s+75eR7J/x8dH+5kJzk4lJrWfC0j6 F34ueqsG3SpYegfd6LAmUok2IWRX/g/T+DX/XksBjjOSp9byjkVuexFUogj/cb4QNNrh IUPQ== MIME-Version: 1.0 References: <20191213150511.2ebeb898@jawa> In-Reply-To: <20191213150511.2ebeb898@jawa> From: Manuel Lauss Date: Fri, 13 Dec 2019 16:58:00 -0000 Message-ID: Subject: Re: 32bit builds broken by gettime64 vDSO patches To: Lukasz Majewski Cc: libc-help@sourceware.org, Adhemerval Zanella , Alistair Francis Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-12/txt/msg00018.txt.bz2 Hi Lukasz, I tried --enable-kernel=3D3.2.0 (Gentoo default), 5.3.0 and 5.4.0, none work. Your patch however does fix the build! Manuel On Fri, Dec 13, 2019 at 3:05 PM Lukasz Majewski wrote: > > Hi Manuel, > > > Hello, > > > > 32bit builds of latest git head (tested x86, MIPS o32, ARM, SH4) > > break on my system; 64 bit (arm64, x86_64) builds are fine. > > Reverting Alistair Francis' 2 clock_gettime64 patches fixes that. > > > > In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: > > ../sysdeps/unix/sysv/linux/clock_gettime.c: In function > > =E2=80=98__clock_gettime64=E2=80=99: ../sysdeps/unix/sysv/linux/sysdep-= vdso.h:40:15: > > error: =E2=80=98__vdso_clock_gettime64=E2=80=99 undeclared (first use i= n this > > function); did you mean =E2=80=98__vdso_clock_gettime=E2=80=99? > > 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ > > | ^~~~~~~ > > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > > | ^~~~~~~~~~~~~~~ > > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:40:15: note: each undeclared > > identifier is reported only once for each function it appears in > > 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ > > | ^~~~~~~ > > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > > | ^~~~~~~~~~~~~~~ > > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:42:15: warning: comparison > > between pointer and integer > > 42 | if (vdsop !=3D NULL) \ > > | ^~ > > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > > | ^~~~~~~~~~~~~~~ > > In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: > > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:44:35: error: called object > > =E2=80=98vdsop=E2=80=99 is not a function or function pointer > > 44 | sc_ret =3D INTERNAL_VSYSCALL_CALL (vdsop, sc_err, nr, ##args); > > \ | ^~~~~ > > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:26:6: note: in definition of > > macro =E2=80=98INTERNAL_VSYSCALL_CALL=E2=80=99 > > 26 | funcptr (args) > > | ^~~~~~~ > > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > > | ^~~~~~~~~~~~~~~ > > In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: > > ../sysdeps/unix/sysv/linux/sysdep-vdso.h:40:30: note: declared here > > 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ > > | ^~~~~ > > ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion > > of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 > > 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); > > | ^~~~~~~~~~~~~~~ > > make[2]: *** > > [/tmp-ram/portage/sys-libs/glibc-2.30-r3/work/build-x86-x86_64-pc-linux= -gnu-nptl/sysd-rules:213: > > /tmp-ram/portage/sys-libs/glibc-2.30-r3/work/build-x86-x86_64-pc-linux-= gnu-nptl/time/clock_gettime.o] > > Error 1 make[2]: Leaving directory > > '/tmp-ram/portage/sys-libs/glibc-2.30-r3/work/glibc-2.30/time' > > > > glibc is configured thusly: > > configure --enable-stack-protector=3Dno > > --enable-stackguard-randomization --disable-cet --enable-kernel=3D5.2.0 > > --without-selinux --without-cvs --disable-werror --enable-bind-now > > --build=3Di686-pc-linux-gnu --host=3Di686-pc-linux-gnu --disable-profile > > --without-gd --with-headers=3D/usr/include --prefix=3D/usr > > --sysconfdir=3D/etc --localstatedir=3D/var --libdir=3D$(prefix)/lib > > --mandir=3D$(prefix)/share/man --infodir=3D$(prefix)/share/info > > --libexecdir=3D$(libdir)/misc/glibc > > --with-bugurl=3Dhttps://bugs.gentoo.org/ --with-pkgversion=3DGentoo > > 2.30-r3 p4 --enable-crypt --disable-systemtap --disable-nscd > > --disable-timezone-tools > > > > Do you use kernel headers > 5.1 but < 5.4 (32 bit) ? > > For 32 bit devices there is a fix available: > https://github.com/lmajewski/y2038_glibc/commit/93a26fc4b3c4c3f57dec539d1= f3244f7ae417be3 > > > > > > Thanks! > > Manuel > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@denx.de