From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116646 invoked by alias); 10 Dec 2019 12:17:29 -0000 Mailing-List: contact libc-help-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: libc-help-owner@sourceware.org Received: (qmail 116636 invoked by uid 89); 10 Dec 2019 12:17:29 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: mail-oi1-f172.google.com Received: from mail-oi1-f172.google.com (HELO mail-oi1-f172.google.com) (209.85.167.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Dec 2019 12:17:27 +0000 Received: by mail-oi1-f172.google.com with SMTP id v10so9536010oiv.12 for ; Tue, 10 Dec 2019 04:17:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to :content-transfer-encoding; bh=6k2b9VUay+x0AT5lHQoIg7Y/HJ/5zTL31J/IiAwZPU8=; b=fW8Q2vFrmAZEOU6gyvjEY2mouvO0eaF8rqojuocg/1l0wSk6P3DaQvE/T17gKl1tfv m277FMqCY2uj9GYxX7uGcyaiZRE8th/1xZqrrn1KJTghTmG+kC2zser5FljCEwLtHDWL uT2WrlRrbnPp3vnwBq2wN16ct9fTHf6Egtyv3HzfDG/TTDO1MfJVHr8OcDqN5YVgYQ2E X6U5WR8AwcAsdNM3QX++E0LLNhr3tz1tkcHF2cRT7h7+T+//q2/9m0PlEBUz9P3mnyg4 iGnME2KHm9D0zml13/FvU/JZJr8J7uO91eHbj5NuNijtMUENJ0intCIqgJLI5qYoyVW4 aNlg== MIME-Version: 1.0 From: Manuel Lauss Date: Tue, 10 Dec 2019 12:17:00 -0000 Message-ID: Subject: 32bit builds broken by gettime64 vDSO patches To: libc-help@sourceware.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2019-12/txt/msg00014.txt.bz2 Hello, 32bit builds of latest git head (tested x86, MIPS o32, ARM, SH4) break on my system; 64 bit (arm64, x86_64) builds are fine. Reverting Alistair Francis' 2 clock_gettime64 patches fixes that. In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: ../sysdeps/unix/sysv/linux/clock_gettime.c: In function =E2=80=98__clock_ge= ttime64=E2=80=99: ../sysdeps/unix/sysv/linux/sysdep-vdso.h:40:15: error: =E2=80=98__vdso_clock_gettime64=E2=80=99 undeclared (first use in this func= tion); did you mean =E2=80=98__vdso_clock_gettime=E2=80=99? 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ | ^~~~~~~ ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); | ^~~~~~~~~~~~~~~ ../sysdeps/unix/sysv/linux/sysdep-vdso.h:40:15: note: each undeclared identifier is reported only once for each function it appears in 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ | ^~~~~~~ ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); | ^~~~~~~~~~~~~~~ ../sysdeps/unix/sysv/linux/sysdep-vdso.h:42:15: warning: comparison between pointer and integer 42 | if (vdsop !=3D NULL) \ | ^~ ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); | ^~~~~~~~~~~~~~~ In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: ../sysdeps/unix/sysv/linux/sysdep-vdso.h:44:35: error: called object =E2=80=98vdsop=E2=80=99 is not a function or function pointer 44 | sc_ret =3D INTERNAL_VSYSCALL_CALL (vdsop, sc_err, nr, ##args); = \ | ^~~~~ ../sysdeps/unix/sysv/linux/sysdep-vdso.h:26:6: note: in definition of macro =E2=80=98INTERNAL_VSYSCALL_CALL=E2=80=99 26 | funcptr (args) | ^~~~~~~ ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); | ^~~~~~~~~~~~~~~ In file included from ../sysdeps/unix/sysv/linux/clock_gettime.c:28: ../sysdeps/unix/sysv/linux/sysdep-vdso.h:40:30: note: declared here 40 | __typeof (__vdso_##name) vdsop =3D __vdso_##name; \ | ^~~~~ ../sysdeps/unix/sysv/linux/clock_gettime.c:41:11: note: in expansion of macro =E2=80=98INLINE_VSYSCALL=E2=80=99 41 | return INLINE_VSYSCALL (clock_gettime64, 2, clock_id, tp); | ^~~~~~~~~~~~~~~ make[2]: *** [/tmp-ram/portage/sys-libs/glibc-2.30-r3/work/build-x86-x86_64= -pc-linux-gnu-nptl/sysd-rules:213: /tmp-ram/portage/sys-libs/glibc-2.30-r3/work/build-x86-x86_64-pc-linux-gnu-= nptl/time/clock_gettime.o] Error 1 make[2]: Leaving directory '/tmp-ram/portage/sys-libs/glibc-2.30-r3/work/glibc-2.30/time' glibc is configured thusly: configure --enable-stack-protector=3Dno --enable-stackguard-randomization --disable-cet --enable-kernel=3D5.2.0 --without-selinux --without-cvs --disable-werror --enable-bind-now --build=3Di686-pc-linux-gnu --host=3Di686-pc-linux-gnu --disable-profile --without-gd --with-headers=3D/usr/include --prefix=3D/usr --sysconfdir=3D/etc --localstatedir=3D/var --libdir=3D$(prefix)/lib --mandir=3D$(prefix)/share/man --infodir=3D$(prefix)/share/info --libexecdir=3D$(libdir)/misc/glibc --with-bugurl=3Dhttps://bugs.gentoo.org/ --with-pkgversion=3DGentoo 2.30-r3 p4 --enable-crypt --disable-systemtap --disable-nscd --disable-timezone-tools Thanks! Manuel