From: Mike Frysinger <vapier@gentoo.org>
To: Peng Yu <pengyu.ut@gmail.com>
Cc: noloader@gmail.com, libc-help <libc-help@sourceware.org>
Subject: Re: Does glibc has complete test coverage?
Date: Tue, 23 Mar 2021 21:17:09 -0400 [thread overview]
Message-ID: <YFqTFU+pBhfPpxCz@vapier> (raw)
In-Reply-To: <CABrM6w=qvV0LxMwNQaEG7KUHKRUdmvMuP5tf2Ue8cy+fBm+FVw@mail.gmail.com>
On 23 Mar 2021 18:09, Peng Yu wrote:
> On Tue, Mar 23, 2021 at 4:02 PM Jeffrey Walton wrote:
> > On Tue, Mar 23, 2021 at 4:43 PM Mike Frysinger wrote:
> > > also try googling for "100% test coverage" and reading the variety of
> > > opinions the wider world has on the topic.
>
> https://blog.ndepend.com/aim-100-percent-test-coverage/
>
> I don't think the so-called "The Diminishing Returns Argument" is
> valid. When you have too many branches to test which rarely occurs in
> practice, this just indicates the code is badly structured. To have
> complete coverage, if the testing code is much more complex than the
> real code, this means that the real code should be restructured to
> make testing code simpler.
there are software ideals, and there's the real world. glibc occupies
the latter. you are welcome to submit patches to try and simplify the
code, but you will have to also not regress on performance, or overall
maintainability. software engineering is about balancing all of these
conflicting requirements.
-mike
next prev parent reply other threads:[~2021-03-24 1:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 16:39 Peng Yu
2021-03-23 20:41 ` Mike Frysinger
2021-03-23 21:02 ` Jeffrey Walton
2021-03-23 23:09 ` Peng Yu
2021-03-24 1:17 ` Mike Frysinger [this message]
2021-03-24 1:13 ` Mike Frysinger
2021-03-24 3:13 ` Peng Yu
2021-03-24 12:31 ` Adhemerval Zanella
2021-03-24 8:32 ` tomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFqTFU+pBhfPpxCz@vapier \
--to=vapier@gentoo.org \
--cc=libc-help@sourceware.org \
--cc=noloader@gmail.com \
--cc=pengyu.ut@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).