From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by sourceware.org (Postfix) with ESMTPS id CDB223858417 for ; Thu, 30 Nov 2023 22:45:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CDB223858417 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=kernel.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CDB223858417 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2604:1380:4601:e00::1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701384313; cv=none; b=sEcG8mNmEXIb5W7olw8LmvYuPAX82mx029m3Jr6/YG8bf8ceJTsWMS71RONx9286CoKmwTZCwGg5IK4PUEqfXq+7XDH11Hm3mmjIpbRXCgGhJZI88gXSsNe5/XVEYS8aO7CD12rdB+iGLRdQlBAig6AhsJvNd3OCh+y9V3vXrno= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701384313; c=relaxed/simple; bh=Upu7m53J/EGjnNawkISAFvg5LlSwEqmn5tMoFmriI7o=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=l6UfsFSBEwQE2zYLXC2mW5GnuqHEXTygBuXT4rRHFk+wUaUAf5Edzs8aZafE95EpUe6W9+2EfiqS+IGrUvq7oU0nsko547pJbXr+Y25RQX9JHoVlXW0kbx+Ts6tVbhiVZZd03vLXSbmXcjrjE/BtkxROAqiPXE+4rjyJEAHZCkA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id C74EEB842F8; Thu, 30 Nov 2023 22:45:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5A1DC433C8; Thu, 30 Nov 2023 22:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701384310; bh=Upu7m53J/EGjnNawkISAFvg5LlSwEqmn5tMoFmriI7o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gw8GiCmYF9MF38yNaQ/hDUmdZDXtHKWicVte5dtusjQfTuZZWqYj1CeoQ8F2V3j7Z Y4UjTrPrkqSSJDuSFro8NZKTNnj5OJjLIhTXrv2AP0OhyB0YFhI1HEWpLSoPcGomMR dTWG1zL+DyPLKRPUDZ7IREVwL7w/Gv6QViOg4ADBCM1EqXSlNoZ4YvbYygjRJDcnEj a3TsT/UERztnv3iGgtxzJIcuT4F1BCYJIPY99CRZCEpCvM57PN8qNLP3Uv3/VYL+x+ x15dm07JxI5ChbNPuiI3tpcFPbo5EKHzKCzHRa/iy+BxLdhQNgkY9rmNpkE5dGWGCc KvL5KRmNbUeow== Date: Thu, 30 Nov 2023 23:45:06 +0100 From: Alejandro Colomar To: Jakub Wilk Cc: Florian Weimer , libc-help@sourceware.org, linux-man@vger.kernel.org, Iker Pedrosa , ~hallyn/shadow@lists.sr.ht, Michael Kerrisk Subject: Re: strtol(3) setting of errno Message-ID: References: <87cyvrv4bl.fsf@oldenburg.str.redhat.com> <20231130221301.nteiaukktf6om6un@jwilk.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="dluxFMjOAqhe4yav" Content-Disposition: inline In-Reply-To: <20231130221301.nteiaukktf6om6un@jwilk.net> X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --dluxFMjOAqhe4yav Content-Type: text/plain; protected-headers=v1; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Date: Thu, 30 Nov 2023 23:45:06 +0100 From: Alejandro Colomar To: Jakub Wilk Cc: Florian Weimer , libc-help@sourceware.org, linux-man@vger.kernel.org, Iker Pedrosa , ~hallyn/shadow@lists.sr.ht, Michael Kerrisk Subject: Re: strtol(3) setting of errno Hi Jakub, On Thu, Nov 30, 2023 at 11:13:01PM +0100, Jakub Wilk wrote: > * Alejandro Colomar , 2023-11-30 13:40: > > Since POSIX doesn't specify, I assume it allows setting errno on > > success, as with any other libc function. That includes setting errno > > on a successful call that returns 0. >=20 > No? "These functions shall not change the setting of errno if successful." Ahhh, I missed that text. Thanks! It means that a simple errno!=3D0 is enough (plus the endptr check), then, and the current page is correct. Cheers, Alex --=20 --dluxFMjOAqhe4yav Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmVpEHIACgkQnowa+77/ 2zJktA/9Fb+FZoVgFHzxEPs7O2E+TwwjO79ef8SbQlbIzjNG4gtiA/5qKNtV0Vr/ LFEV/RywpqGIizBG9U9YQK97cYadvHkw4xplR0MEZv6UckpvHOtsu1XcMKxWav/i nt0uPT9RVCaC/HCywxzSUDkva/XxKmpY1A7oSl5F2ZxlpsKs+Cn9SjKdjjG/ia1+ +PDgv/El+FgCHF0p0w5ZSKnIOrns9ONB92lNbl6wtKfksp0kBTWljgejptIUlnl1 PoKcApA+mlEfBML15ftnIk49JLqaXWwSrB847in/g+GNlHF/btuqdkBkNznTIxgu oId3O2S3l06R0D6T4aHRoPytDkM49WTUe4l6aDfcOwIM+C3fACi6wLIcMJhlVH22 ULlCjkMKPLHiASI2Xv9UMlMMlE/iVtgeIE4YBhrXtrGfEwk06ror8urO3b23STsx dZ6EuUrLDEx8+uzg5uGBPt82txhiQo/fWi+nFESpYLe+gWvOjgEY01wXYR7BsVZb gIPEaNtpNZpShxhvp3dszvUcns+SVdoN5B5PHpKXqqB7HyT9bIn7rgupk4W1yj9G JVOFu3UjEAkrUx81hF6usiaaYusBmXQcLaW/BiKePOxoXtmZPRCc0MY8B4S+Cu+C CP+NrrbT5t/Hke10kuG5AwxJ+c58JF6VT7R/VmViCI9ZCC2WDtQ= =NAYI -----END PGP SIGNATURE----- --dluxFMjOAqhe4yav--