From: Joseph Myers <joseph@codesourcery.com>
To: Stefan Kanthak <stefan.kanthak@t-online.de>
Cc: Szabolcs Nagy <szabolcs.nagy@arm.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
<libc-help@sourceware.org>, <libc-alpha@sourceware.org>
Subject: Re: [PATCH/2nd version] Re: nextafter() about an order of magnitude slower than trivial implementation
Date: Fri, 20 Aug 2021 16:55:59 +0000 [thread overview]
Message-ID: <alpine.DEB.2.22.394.2108201654040.407143@digraph.polyomino.org.uk> (raw)
In-Reply-To: <AEC2AFE4A2D94C449A5ED31A392459C0@H270>
On Fri, 20 Aug 2021, Stefan Kanthak wrote:
> if(ax > 0x7ffull << 53) /* x is nan */
> return x;
> if(ay > 0x7ffull << 53) /* y is nan */
> return y;
How has this been tested? I'd have expected it to fail the nextafter
tests in the glibc testsuite (libm-test-nextafter.inc), because they
verify that sNaN arguments produce a qNaN result with the "invalid"
exception raised, and this looks like it would just return an sNaN
argument unchanged.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2021-08-20 16:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 16:03 Stefan Kanthak
2021-08-18 12:51 ` Szabolcs Nagy
2021-08-18 17:11 ` Stefan Kanthak
2021-08-19 11:20 ` Adhemerval Zanella
2021-08-19 17:57 ` [PATCH] " Stefan Kanthak
2021-08-20 9:52 ` [PATCH/2nd version] " Stefan Kanthak
2021-08-20 16:55 ` Joseph Myers [this message]
2021-08-20 20:19 ` Stefan Kanthak
2021-08-20 21:03 ` Joseph Myers
2021-08-23 12:50 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2108201654040.407143@digraph.polyomino.org.uk \
--to=joseph@codesourcery.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=libc-help@sourceware.org \
--cc=stefan.kanthak@t-online.de \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).