From: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
To: Olivier Dion <odion@efficios.com>, libc-help@sourceware.org
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Subject: Re: Dead code in pthread_cond_wait() for spin-wait
Date: Wed, 11 Oct 2023 15:57:34 -0300 [thread overview]
Message-ID: <d38585f6-d896-47bc-8716-1a0a671f7f45@linaro.org> (raw)
In-Reply-To: <87a5spvwoi.fsf@laura>
On 11/10/23 15:30, Olivier Dion via Libc-help wrote:
> Hi,
>
> Commit ed19993b5b0d05d62cc883571519a67dae481a14 from 2016 introduce "a
> new implementation of condition variables". This new implementation
> seems to introduce a spin-wait fast-path to avoid taking the underlying
> futex when doing a pthread_cond_wait().
>
> However, looking at the following snippet in nptl/pthread_cond_wait.c:
>
> static __always_inline int
> __pthread_cond_wait_common (pthread_cond_t *cond, pthread_mutex_t *mutex,
> clockid_t clockid, const struct __timespec64 *abstime)
> {
> const int maxspin = 0;
> [...]
> /* Spin-wait first. [...] */
> unsigned int spin = maxspin;
> while (signals == 0 && spin > 0) {
> [...]
> }
> [...]
> }
>
Afaik it was added a placeholder for future extension, so fell free to
send a patch to delete it.
> it seems to me that the try-spinning portion is dead code in
> pthread_cond_wait_common(). I was wondering why this was the case?
>
> I also think that there would maybe some interest in using the Userspace
> RCU wait algorithm [0] for this.
>
> [0] https://github.com/urcu/userspace-rcu/blob/master/src/urcu-wait.h
>
> Thanks,
>
> Olivier
>
next prev parent reply other threads:[~2023-10-11 18:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-11 18:30 Olivier Dion
2023-10-11 18:36 ` Mathieu Desnoyers
2023-10-11 18:57 ` Adhemerval Zanella Netto [this message]
2023-10-12 15:45 ` Olivier Dion
2023-10-12 16:40 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d38585f6-d896-47bc-8716-1a0a671f7f45@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=libc-help@sourceware.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=odion@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).