From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8247 invoked by alias); 5 Jan 2019 21:13:23 -0000 Mailing-List: contact libc-locales-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-locales-owner@sourceware.org Received: (qmail 8216 invoked by uid 89); 5 Jan 2019 21:13:22 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=sole, Country, en_us, en_US X-HELO: mout.kundenserver.de Subject: Re: [PATCH v12] Locales: Cyrillic -> ASCII transliteration [BZ #2872] To: Rafal Luzynski , libc-alpha@sourceware.org, libc-locales@sourceware.org, Carlos O'Donell , Siddhesh Poyarekar Cc: Marko Myllynen , mfabian@redhat.com References: <41532e13-a63d-5df1-ab37-05eb4d6c8d0a@kobylkin.com> <20180412224352.GB2911@altlinux.org> <2124833400.35614.1546698902753@poczta.nazwa.pl> From: Egor Kobylkin Message-ID: <908ed415-cfe4-804c-f421-4351ef062edc@kobylkin.com> Date: Sat, 05 Jan 2019 21:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <2124833400.35614.1546698902753@poczta.nazwa.pl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-q1/txt/msg00018.txt.bz2 On 05.01.19 15:35, Rafal Luzynski wrote: > 2.01.2019 19:38 Egor Kobylkin wrote: >> >> Changelog v12: >> [...] >> >> Changelog v11: >> * Re-targeted the patch against locale/C-translit.h.in as the proper >> file for the ASCII translit table. >> * Correspondingly the patch now only contains the additional >> Cyrillic-ASCII strings in the format of locale/C-translit.h.in table. >> The 'include "translit_cyrillic";""' directives are not necessary in the >> locale files and they are now all left intact. >> * Also the file translit_cyrillic is not longer needed and is omitted. >> * Edited below email, commit message. >> [...] > > I have tested this and, unfortunately, now this transliteration > works *only* in C locale, that is, only when no locale is set or when > it is explicitly set to C (C.UTF8, POSIX). It does not work when locale > is set to anything different, including en_US, ru_RU, etc. > > I'm sorry for confusing you. I think that either we should revert back > to the older versions of your patch to make all locales supported or > merge those two versions to make the transliteration work both in > C and in all (almost all) other locales. Unfortunately, C locale is > not a base for all other locales and is not included, it is only a fallback > when a locale does not provide its own data (that is, when it does not > provide any transliteration table at all). Good catch! Should we maybe split this into two patches, one for C and the other for "country" locales? They have different codes and functionality so it looks like it would be easier to keep focus. My understanding is that locale/C-translit.h.in is still the proper locale for the sole ASCII translit table. It is also the only solution for many use cases where there is no locale available (not compiled or not set). "Country" locales in localedata/locales/ can then have the exact same translit table included or they can have any other flavor - I don't see a problem here. Best regards, Egor