From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117028 invoked by alias); 24 Aug 2017 03:54:36 -0000 Mailing-List: contact libc-locales-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-locales-owner@sourceware.org Received: (qmail 114299 invoked by uid 48); 24 Aug 2017 03:54:30 -0000 From: "akhilesh.k at samsung dot com" To: libc-locales@sourceware.org Subject: [Bug localedata/21971] Added New Locale for mfe_MU Date: Sat, 26 Aug 2017 10:54:00 -0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: glibc X-Bugzilla-Component: localedata X-Bugzilla-Version: 2.26 X-Bugzilla-Keywords: X-Bugzilla-Severity: normal X-Bugzilla-Who: akhilesh.k at samsung dot com X-Bugzilla-Status: UNCONFIRMED X-Bugzilla-Resolution: X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: unassigned at sourceware dot org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: security- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: http://sourceware.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-SW-Source: 2017-q3/txt/msg00521.txt.bz2 https://sourceware.org/bugzilla/show_bug.cgi?id=3D21971 --- Comment #2 from Akhilesh Kumar --- > > DEFINE_LANGUAGE_CODE ("Marshallese", mh, mah, mah) > > DEFINE_LANGUAGE_CODE3 ("Marwari", mwr, mwr) > > DEFINE_LANGUAGE_CODE3 ("Masai", mas, mas) >> +DEFINE_LANGUAGE_CODE3 ("Mauritius", mfe, mfe) >=20 > =E2=80=9CMauritius=E2=80=9D is the name of the country. > The name of the language in English should be =E2=80=9CMauritian Creole= =E2=80=9D or > =E2=80=9CMorisyen=E2=80=9D. Changes done=20 > > DEFINE_LANGUAGE_CODE3 ("Mayan languages", myn, myn) >> DEFINE_LANGUAGE_CODE3 ("Meadow Mari", mhr, mhr) > > DEFINE_LANGUAGE_CODE3 ("Mende", men, men) > > diff --git a/localedata/SUPPORTED b/localedata/SUPPORTED > > index 197917b..e8f4764 100644 > > --- a/localedata/SUPPORTED > > +++ b/localedata/SUPPORTED > > @@ -311,6 +311,7 @@ lzh_TW/UTF-8 \ > > mag_IN/UTF-8 \ >=20 > > + "lin";/ > > + "mar";/ >> + "mer";/ > > + "ze ";/ > > + "van";/ > > + "sam" >=20 > Could you use the whitespace in a consistant way instead of a mixture > of tabs and spaces? Changes Done=20 > > +% > > +% Full weekday names > > +day "dimans";/ > > + "lindi";/ > > + "mardi";/ > > + "merkredi";/ > > + "zedi";/ > > + "vandredi";/ > > + "samdi" > > + "desam" > > +% > > +d_t_fmt "<= U0020>" >> +d_fmt "" > > +t_fmt "" > > +am_pm "AM";"PM" > > +t_fmt_ampm "<= U0020>" > > +date_fmt "/ > > +/ > > +" >> +END LC_TIME >=20 > These are all ASCII, so you could write the text directly here as well > instead of the code points. Done=20=20 > > +% http://wikitravel.org/en/User:LiangHH/Mauritian_Creole_phrasebook > > +LC_MESSAGES > > +yesexpr "[+1yY]" > >=20 > > could be written directly, i.e. >=20 >yesexpr "^[+1yY] >=20 > > +noexpr "[-0nN]" >=20 > Why is the ^ missing here? Done=20=20 > > +yesstr "Yes" >> +nostr "No" > > +END LC_MESSAGES > > +int_curr_symbol "MUR " >> +currency_symbol "Rs" >=20 > According to the Wikipedia page you quote, this should be =E2=80=9C=E2=82= =A8=E2=80=9D, not =E2=80=9CRs=E2=80=9D. Agree > > +mon_decimal_point "." > > +mon_thousands_sep "," >=20 >According to mfe.xml in CLDR, U+00A0 NO-BREAK SPACE is used as a > thousands separator. So we should not use =E2=80=9C,=E2=80=9D but=E2=80= =AF U+202F NARROW > NO-BREAK SPACE (We consistently use the narrow version in thousands_sep > and mon_thousands_sep in glibc currently). Agree=20=20 > > +mon_grouping 3;3 > > +positive_sign "" > > +negative_sign "-" > > +int_frac_digits 2 > > +frac_digits 2 > > +p_cs_precedes 1 > > +int_p_sep_by_space 1 > > +p_sep_by_space 1 >> +n_cs_precedes 1 > > +int_n_sep_by_space 1 > > +n_sep_by_space 1 > > +p_sign_posn 1 > > +n_sign_posn 1 > > +% > > +END LC_MONETARY >> + > > +LC_NUMERIC > > +decimal_point "." > > +thousands_sep "," >=20 > According to mfe.xml in CLDR, U+00A0 NO-BREAK SPACE is used as a > thousands separator. So we should not use =E2=80=9C,=E2=80=9D but=E2=80= =AF U+202F NARROW > NO-BREAK SPACE (We consistently use the narrow version in thousands_sep > and mon_thousands_sep in glibc currently). Changes Done=20=20 > > +grouping 3 > > +END LC_NUMERIC > > + >> +LC_PAPER > > +copy "i18n" > > +END LC_PAPER > > + > > +LC_TELEPHONE > > +% https://www.howtocallabroad.com/mauritius/ > > +tel_int_fmt "+%c %l" >> +% 00 Africa: all countries except Kenya, Nigeria, Tanzania and Uganda > > +int_select "00" > > +int_prefix "230" > > +END LC_TELEPHONE > > + > > +LC_MEASUREMENT > > +copy "i18n" > > +END LC_MEASUREMENT > > + > > + > > + > > +LC_NAME > > +name_fmt "/ >> +" >=20 > Could be written directly because it is ASCII. Done=20=20 > > +name_miss "Miss." > > +name_mr "Mr." > > +name_mrs "Mrs." >> +name_ms "Ms." > > +END LC_NAME > > + > > + > > +LC_ADDRESS > > +postal_fmt "%f%N%h%s%N%T" > > +country_name "Mauritius" > > +country_ab2 "MU" > > +country_ab3 "MUS" > > +country_num 480 > +% https://en.wikipedia.org/wiki/List_of_international_vehicle_registrati= on_codes > +country_car "MS" > +country_isbn "978-613,978-620,978-99903,978-99949" > +lang_name "Morisyen" >=20 > According to mfe.xml in CLDR, this should be =E2=80=9Ckreol morisien=E2= =80=9D, > Wikipedia has it capitalized as =E2=80=9CKreol Morisien=E2=80=9D. I think= we should >follow CLDR here. Done=20=20 > > +lang_ab "mfe" >=20 > lang_ab should contain the iso-639-1 code, but as there is no iso-639-1 > code for Morisyen, it should be empty or omitted, I think. >=20 >> +lang_term "mfe" > > +lang_lib "mfe" >=20 > I think lang_lib is the iso-639-2 code and there is no iso-639-2 > code for Morisyen either, only iso-639-3. >=20 > I am not sure what one should do in such a case. I guess using the > iso-639-3 code in lang_lib as well is OK,=20 Thanks Mike for nice review all above comments are integrated=20 https://sourceware.org/ml/libc-alpha/2017-08/msg01099.html > > +END LC_ADDRESS --=20 You are receiving this mail because: You are on the CC list for the bug.