[Bug localedata/23094] New: hr_HR: wrong thousands_sep and mon_thousands_sep

[Bug localedata/23094] New: hr_HR: wrong thousands_sep and mon_thousands_sep

[kkovacev at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

            Bug ID: 23094
           Summary: hr_HR: wrong thousands_sep and mon_thousands_sep
           Product: glibc
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: localedata
          Assignee: unassigned at sourceware dot org
          Reporter: kkovacev at gmail dot com
                CC: libc-locales at sourceware dot org
  Target Milestone: ---

hr_HR file has wrong values for thousands_sep and mon_thousands_sep.
Current value is "<U202F>" it should be "."

Arguments for this change:

1)
 CLDR uses "." for grouping and "," as the decimal point.
 See common/main/hr.xml file.
2)
 All CNB (Croatian National Bank) reports has . as thousands separator 
(www.hnb.hr).
3)
 All receipts that you will see in Croatia has . as thousands separator.
4)
 All banking apps use . as thousands separator (checked few random banks).
5)
 Browsed through Croatian Constitution, again "." as thousands separator.
6)
 Croatian Ministry of Finance use ".".
7)And most unpopular reason that I can think of: 
Windows 10 (and all previous  versions) has "." as thousands and "," for
decimal separator (numeric and monetary). You just forced me to find pc with
windows :D

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[kkovacev at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

Krešimir Kovačević <kkovacev at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |2.27

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[kkovacev at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

--- Comment #1 from Krešimir Kovačević <kkovacev at gmail dot com> ---
Created attachment 10965
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10965&action=edit
hr_HR patched file

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[kkovacev at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

Krešimir Kovačević <kkovacev at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kkovacev at gmail dot com

--- Comment #2 from Krešimir Kovačević <kkovacev at gmail dot com> ---
I have also browsed through older versions of glibc.
It seems that all have wrong separators for thousands and decimal.
thousands should be "." and decimal should be ",".

BR,
Krešimir

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[invisible@hidden-city.net]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

Dragan Stanojevic - Nevidljivi <invisible@hidden-city.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |invisible@hidden-city.net

--- Comment #3 from Dragan Stanojevic - Nevidljivi <invisible@hidden-city.net> ---
Created attachment 10966
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10966&action=edit
Fixing mon_thousands_sep and thousands_sep to ","

OK, bug report and arguments for it are valid.

Provided patch isn't a patch but a full localedata file. Therefore this patch
is provided which changes only affected portion of the locale.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

Mike FABIAN <maiku.fabian at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maiku.fabian at gmail dot com
           Assignee|unassigned at sourceware dot org   |maiku.fabian at gmail dot com

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[kkovacev at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

--- Comment #4 from Krešimir Kovačević <kkovacev at gmail dot com> ---
Hi Dragan,

Your patch is OK.
But in comment you written "," in instead "."

BR,
Krešimir

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[invisible@hidden-city.net]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

--- Comment #5 from Dragan Stanojevic - Nevidljivi <invisible@hidden-city.net> ---
Fixed comment :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[invisible@hidden-city.net]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

Dragan Stanojevic - Nevidljivi <invisible@hidden-city.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #10966|Fixing mon_thousands_sep    |Fixing mon_thousands_sep
        description|and thousands_sep to ","    |and thousands_sep to "."

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

--- Comment #6 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  ea76691a7507b052a15b9dddb5847afa2b57d2a4 (commit)
      from  573963e32ffac46d9891970ddebde2ac3212c5c0 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ea76691a7507b052a15b9dddb5847afa2b57d2a4

commit ea76691a7507b052a15b9dddb5847afa2b57d2a4
Author: Dragan Stanojevic - Nevidljivi <invisible@hidden-city.net>
Date:   Mon Apr 23 16:54:31 2018 +0200

    hr_HR locale: fix thousands_sep and mon_thousands_sep

        [BZ #23094]
        * localedata/locales/hr_HR: fix thousands_sep and
        mon_thousands_sep

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                |    6 ++++++
 localedata/locales/hr_HR |    4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

Mike FABIAN <maiku.fabian at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
   Target Milestone|---                         |2.28

--- Comment #7 from Mike FABIAN <maiku.fabian at gmail dot com> ---
Fixed in glibc master

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[joseph at codesourcery dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

--- Comment #8 from joseph at codesourcery dot com <joseph at codesourcery dot com> ---
How was this commit tested?  I'm seeing failures of stdlib/tst-strfmon_l 
now, for locale hr_HR.UTF-8.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[tuliom at linux dot ibm.com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

Tulio Magno Quites Machado Filho <tuliom at linux dot ibm.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tuliom at linux dot ibm.com

--- Comment #9 from Tulio Magno Quites Machado Filho <tuliom at linux dot ibm.com> ---
(In reply to joseph@codesourcery.com from comment #8)
> I'm seeing failures of stdlib/tst-strfmon_l now, for locale hr_HR.UTF-8.

For the record: a fix for those errors has been proposed at
https://sourceware.org/ml/libc-alpha/2018-04/msg00491.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[maiku.fabian at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

--- Comment #10 from Mike FABIAN <maiku.fabian at gmail dot com> ---
(In reply to joseph@codesourcery.com from comment #8)
> How was this commit tested?  I'm seeing failures of stdlib/tst-strfmon_l 
> now, for locale hr_HR.UTF-8.

Sorry, I thought I had run make check but apparently I just looked
at the result from a previous run.

I’ll fix it immediately!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug localedata/23094] hr_HR: wrong thousands_sep and mon_thousands_sep

[cvs-commit at gcc dot gnu.org]

https://sourceware.org/bugzilla/show_bug.cgi?id=23094

--- Comment #11 from cvs-commit at gcc dot gnu.org <cvs-commit at gcc dot gnu.org> ---
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  e5aea5c314f1f2c4e31e2ca29578ca1a9f2b9b55 (commit)
      from  9320ca88a197d3620d3553ccc2d9402d981d7e23 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e5aea5c314f1f2c4e31e2ca29578ca1a9f2b9b55

commit e5aea5c314f1f2c4e31e2ca29578ca1a9f2b9b55
Author: Mike FABIAN <mfabian@redhat.com>
Date:   Tue Apr 24 15:04:43 2018 +0200

    Fix tst-strfmon_l test for hr_HR locale

    The test needs to be adapted for the change in the thousands separators:

    “hr_HR locale: fix thousands_sep and mon_thousands_sep” [BZ #23094]

-----------------------------------------------------------------------

Summary of changes:
 stdlib/tst-strfmon_l.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.