From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sourceware-bugzilla@sourceware.org>
Received: by sourceware.org (Postfix, from userid 48)
 id 596F03938C0A; Wed,  3 Feb 2021 21:13:02 +0000 (GMT)
DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 596F03938C0A
From: "joseph at codesourcery dot com" <sourceware-bugzilla@sourceware.org>
To: libc-locales@sourceware.org
Subject: [Bug localedata/27320] localedata/gen-locale.sh failure in native
 build is ignored
Date: Wed, 03 Feb 2021 21:13:02 +0000
X-Bugzilla-Reason: CC
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: glibc
X-Bugzilla-Component: localedata
X-Bugzilla-Version: 2.34
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: normal
X-Bugzilla-Who: joseph at codesourcery dot com
X-Bugzilla-Status: NEW
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: P2
X-Bugzilla-Assigned-To: unassigned at sourceware dot org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: security-
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-27320-716-aTNXU5vJyf@http.sourceware.org/bugzilla/>
In-Reply-To: <bug-27320-716@http.sourceware.org/bugzilla/>
References: <bug-27320-716@http.sourceware.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: http://sourceware.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: libc-locales@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Libc-locales mailing list <libc-locales.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/libc-locales>,
 <mailto:libc-locales-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/libc-locales/>
List-Help: <mailto:libc-locales-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/libc-locales>,
 <mailto:libc-locales-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Feb 2021 21:13:02 -0000

https://sourceware.org/bugzilla/show_bug.cgi?id=3D27320

--- Comment #8 from joseph at codesourcery dot com <joseph at codesourcery =
dot com> ---
An appropriate fix would be to make any failure in=20
localedata/gen-locale.sh produce a FAIL for the generated locale.

The first step in that is that gen-locale.sh should exit with error status=
=20
on error from localedef, which it looks to me like it does (an explicit=20
"exit 1").  The second step is that the makefile rule should use=20
$(evaluate-test), which it also does (in gen-locales.mk).  So there are a=20
few other issues to resolve:

* The locales should be listed in tests-special (like how=20
timezone/Makefile does

tests-special +=3D $(addprefix $(testdata)/, $(test-zones))

to get files built by zic listed as tests, for example).

* That listing in tests-special probably needs to be in the localedata/=20
directory as that's where the files in question are built.

* Then the FAIL would be in localedata/subdir-tests.sum.

* But you're using subdirs=3Dstring which prevents FAILs outside=20
string/subdir-tests.sum from being considered in the process of merging=20
FAILs from subdirectories.  Fixing the points above should ensure a FAIL=20
when gen-locale.sh fails in a full testsuite run, but getting one if=20
you're only building a non-localedata subdirectory may be harder.

--=20
You are receiving this mail because:
You are on the CC list for the bug.=