From: Mike FABIAN <mfabian@redhat.com>
To: RushingAlien via Libc-locales <libc-locales@sourceware.org>
Cc: RushingAlien <rushing27alien@gmail.com>
Subject: Re: [PATCH] id_ID: Update Time Locales
Date: Mon, 18 Dec 2023 17:07:45 +0100 [thread overview]
Message-ID: <s9dedfjije6.fsf@hathi.site> (raw)
In-Reply-To: <20230821035729.9472-2-rushing27alien@gmail.com> (RushingAlien via Libc-locales's message of "Mon, 21 Aug 2023 10:57:30 +0700")
Committed.
RushingAlien via Libc-locales <libc-locales@sourceware.org> さんはかきました:
> Hello! I am Indonesian, was born and raised in Indonesia and still do live in
> Indonesia.
> I have sent this to libc-alpha, however had received no response, so I
> am sending it here.
>
> This patch brings a few changes to the time locales of id_ID, which
> includes :
> \- Defining am_pm and time_fmpt_ampm
> \- Changing time_fmt and d_t_fmt to use the 24-hour format
> \- Changing first_weekday to Monday
> This is a squashed version of what is previously a 5 patch set
>
> Here are reasons and details of the changes :
>
> Change 1 part 1
>
> id_ID: Define `am_pm` string
>
> Current formatting does not define am_pm string, leading to AM and PM
> not being specified in 12 H time format. This change defines the string
> by changing it from an empty string to "AM";"PM".
>
> output of `date +%r`:
> before commit: 01:23
> after commit: 01:23 PM
>
> Change 1 part 2
>
> id_ID: Define time_fmt_ampm, change from an empty string
>
> Currently, time_fmpt_ampm is set to an empty string, causing some
> programs to not be able to display time in the 12-hour format, for
> example, glib: https://gitlab.gnome.org/GNOME/glib/-/issues/2967.
> This commit changes it from an empty string to "%I:%M:%S %p"
>
> Change 2 part 1
>
> id_ID: Use 24-hour format for time_fmt
>
> Indonesian standard and formal time format uses the 24-hour format inst-
> ead of the 12-hour format. This commit aims to change the id_ID locale's
> time_fmt to match that accordingly.
>
> Change 2 part 2
>
> id_ID: Use 24-hour format for d_t_fmt.
>
> Indonesian standard and formal time format uses the 24-hour format inst-
> ead of the 12-hour format. This commit aims to change the id_ID locale's
> d_t_fmt to match that accordingly.
>
> Change 3
>
> id_ID: Change first_weekday to monday
>
> Indonesian calendar starts of the week wiht Monday, let's comply
> ---
> localedata/locales/id_ID | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/localedata/locales/id_ID b/localedata/locales/id_ID
> index c10306deb7..5957ebaf0f 100644
> --- a/localedata/locales/id_ID
> +++ b/localedata/locales/id_ID
> @@ -115,13 +115,14 @@ mon "Januari";/
> "Oktober";/
> "November";/
> "Desember"
> -d_t_fmt "%a %d %b %Y %r"
> -date_fmt "%a %d %b %Y %r %Z"
> +d_t_fmt "%a %d %b %Y %T"
> +date_fmt "%a %d %b %Y %T %Z"
> d_fmt "%d//%m//%y"
> t_fmt "%T"
> -am_pm "";""
> -t_fmt_ampm ""
> +am_pm "AM";"PM"
> +t_fmt_ampm "%I:%M:%S %p"
> week 7;19971130;1
> +first_weekday 2
> END LC_TIME
>
> LC_MESSAGES
--
Mike FABIAN <mfabian@redhat.com>
睡眠不足はいい仕事の敵だ。
prev parent reply other threads:[~2023-12-18 16:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 3:57 RushingAlien
2023-12-18 16:07 ` Mike FABIAN [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s9dedfjije6.fsf@hathi.site \
--to=mfabian@redhat.com \
--cc=libc-locales@sourceware.org \
--cc=rushing27alien@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).