From: Abhishek Deb <adeb@nvidia.com>
To: Joseph Myers <joseph@codesourcery.com>,
Dinar Temirbulatov <dtemirbulatov@gmail.com>
Cc: "libc-ports@sourceware.org" <libc-ports@sourceware.org>,
Maxim Kuvyrkov <maxim@kugelworks.com>
Subject: RE: [Patch] ARM define atomic_exchange_acq/atomic_exchange_rel to __atomic_exchange_n
Date: Thu, 05 Sep 2013 17:09:00 -0000 [thread overview]
Message-ID: <0E42B6C0C4628E48B8DF5D3F3C8FCA8898F2CF5F17@HQMAIL02.nvidia.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1309051542360.28271@digraph.polyomino.org.uk>
Compilation with 4.8.0 succeeded, whereas compilation with 4.6.2 failed due to the trailing $ as pointed by Joseph.
Abhishek
-----Original Message-----
From: Joseph Myers [mailto:joseph@codesourcery.com]
Sent: Thursday, September 05, 2013 8:48 AM
To: Dinar Temirbulatov
Cc: libc-ports@sourceware.org; Abhishek Deb; Maxim Kuvyrkov
Subject: Re: [Patch] ARM define atomic_exchange_acq/atomic_exchange_rel to __atomic_exchange_n
On Thu, 5 Sep 2013, Dinar Temirbulatov wrote:
> Hi,
> Here is updated version of change. Ok to commit?
You appear to insert a '$' after '\' on one line - that can't be right.
Please try to test all three cases in the code.
Where you have "typeof(*mem)", there should be a space before the '('.
--
Joseph S. Myers
joseph@codesourcery.com
next prev parent reply other threads:[~2013-09-05 17:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-01 20:43 Dinar Temirbulatov
2013-09-02 15:08 ` Joseph S. Myers
2013-09-03 17:31 ` Abhishek Deb
2013-09-05 12:56 ` Dinar Temirbulatov
2013-09-05 15:48 ` Joseph S. Myers
2013-09-05 17:09 ` Abhishek Deb [this message]
2013-09-11 19:25 ` Dinar Temirbulatov
2013-09-11 19:27 ` Dinar Temirbulatov
2013-09-11 20:40 ` Abhishek Deb
2013-09-13 17:14 ` Joseph S. Myers
2013-09-14 3:29 ` Dinar Temirbulatov
2013-09-18 17:16 ` Joseph S. Myers
2013-09-19 6:53 ` Maxim Kuvyrkov
2013-09-19 16:29 ` Joseph S. Myers
-- strict thread matches above, loose matches on Subject: below --
2013-09-01 20:42 Dinar Temirbulatov
2013-08-13 17:11 Dinar Temirbulatov
2013-08-15 21:46 ` Abhishek Deb
2013-08-16 22:57 ` Dinar Temirbulatov
2013-08-17 2:42 ` Abhishek Deb
2013-08-19 19:21 ` Dinar Temirbulatov
2013-08-18 20:29 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0E42B6C0C4628E48B8DF5D3F3C8FCA8898F2CF5F17@HQMAIL02.nvidia.com \
--to=adeb@nvidia.com \
--cc=dtemirbulatov@gmail.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=maxim@kugelworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).