From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2674 invoked by alias); 5 Sep 2013 17:09:46 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 2659 invoked by uid 89); 5 Sep 2013 17:09:45 -0000 Received: from hqemgate14.nvidia.com (HELO hqemgate14.nvidia.com) (216.228.121.143) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Thu, 05 Sep 2013 17:09:45 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RDNS_NONE,SPF_PASS autolearn=no version=3.3.2 X-HELO: hqemgate14.nvidia.com Received: from hqnvupgp08.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com id ; Thu, 05 Sep 2013 10:09:26 -0700 Received: from hqemhub03.nvidia.com ([172.20.12.94]) by hqnvupgp08.nvidia.com (PGP Universal service); Thu, 05 Sep 2013 10:06:52 -0700 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Thu, 05 Sep 2013 10:06:52 -0700 Received: from HQMAIL02.nvidia.com ([172.20.150.111]) by hqemhub03.nvidia.com ([172.20.150.15]) with mapi; Thu, 5 Sep 2013 10:09:42 -0700 From: Abhishek Deb To: Joseph Myers , Dinar Temirbulatov CC: "libc-ports@sourceware.org" , Maxim Kuvyrkov Date: Thu, 05 Sep 2013 17:09:00 -0000 Subject: RE: [Patch] ARM define atomic_exchange_acq/atomic_exchange_rel to __atomic_exchange_n Message-ID: <0E42B6C0C4628E48B8DF5D3F3C8FCA8898F2CF5F17@HQMAIL02.nvidia.com> References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-SW-Source: 2013-09/txt/msg00047.txt.bz2 Compilation with 4.8.0 succeeded, whereas compilation with 4.6.2 failed due= to the trailing $ as pointed by Joseph. Abhishek -----Original Message----- From: Joseph Myers [mailto:joseph@codesourcery.com]=20 Sent: Thursday, September 05, 2013 8:48 AM To: Dinar Temirbulatov Cc: libc-ports@sourceware.org; Abhishek Deb; Maxim Kuvyrkov Subject: Re: [Patch] ARM define atomic_exchange_acq/atomic_exchange_rel to = __atomic_exchange_n On Thu, 5 Sep 2013, Dinar Temirbulatov wrote: > Hi, > Here is updated version of change. Ok to commit? You appear to insert a '$' after '\' on one line - that can't be right.=20= =20 Please try to test all three cases in the code. Where you have "typeof(*mem)", there should be a space before the '('. --=20 Joseph S. Myers joseph@codesourcery.com