From: Steve Ellcey <sellcey@mips.com>
To: "Joseph S. Myers" <joseph@codesourcery.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: Building syscall.h on mips
Date: Tue, 22 May 2012 22:40:00 -0000 [thread overview]
Message-ID: <1337726427.21213.155.camel@ubuntu-sellcey> (raw)
In-Reply-To: <Pine.LNX.4.64.1205222106320.8022@digraph.polyomino.org.uk>
On Tue, 2012-05-22 at 21:10 +0000, Joseph S. Myers wrote:
> On Tue, 22 May 2012, Steve Ellcey wrote:
>
> > So, does this second patch look OK for glibc-ports for MIPS?
>
> No, it's definitely wrong. The header needs to have three sections, each
> one with the syscalls relevant to that particular ABI. Those sets are
> similar, but not the same. The MIPS build of this header was broken for a
> long time (see
> <http://sourceware.org/ml/libc-alpha/2011-12/msg00046.html>).
>
> If you can't get -m options working there, maybe it's necessary to use
> entirely -U and -D options in the -options variables - those options being
> such as to make the MIPS asm/unistd.h define the correct set of syscalls
> for each ABI.
Ok, I think I have it now. With these -D flags, I get similar but not
identical sets for the three ifdef's. I would have liked to use
_MIPS_SIM_ABI32, etc in the -D instead of 1,2,3 but that did not seem to
work.
How does this patch look?
Steve Ellcey
sellcey@mips.com
diff --git a/sysdeps/unix/sysv/linux/mips/Makefile
b/sysdeps/unix/sysv/linux/mip
index 41e9258..2aaf63c 100644
--- a/sysdeps/unix/sysv/linux/mips/Makefile
+++ b/sysdeps/unix/sysv/linux/mips/Makefile
@@ -7,13 +7,14 @@ sysdep_routines += cachectl cacheflush sysmips
_test_and_set
sysdep_headers += sys/cachectl.h sys/sysmips.h sys/tas.h
+# _MIPS_SIM_ABI32 == 1, _MIPS_SIM_ABIN32 == 2, _MIPS_SIM_ABI64 == 3
syscall-list-variants := o32 n32 n64
syscall-list-includes := sgidefs.h
-syscall-list-o32-options := -mabi=32
+syscall-list-o32-options := -D_MIPS_SIM=1
syscall-list-o32-condition := _MIPS_SIM == _MIPS_SIM_ABI32
-syscall-list-n32-options := -mabi=n32
+syscall-list-n32-options := -D_MIPS_SIM=2
syscall-list-n32-condition := _MIPS_SIM == _MIPS_SIM_ABIN32
-syscall-list-n64-options := -mabi=64
+syscall-list-n64-options := -D_MIPS_SIM=3
syscall-list-n64-condition := _MIPS_SIM == _MIPS_SIM_ABI64
endif
next prev parent reply other threads:[~2012-05-22 22:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-22 21:02 Steve Ellcey
2012-05-22 21:10 ` Joseph S. Myers
2012-05-22 22:40 ` Steve Ellcey [this message]
2012-05-23 0:06 ` Joseph S. Myers
2012-05-23 15:47 ` Steve Ellcey
2012-05-23 18:49 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337726427.21213.155.camel@ubuntu-sellcey \
--to=sellcey@mips.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).