From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28721 invoked by alias); 21 Sep 2012 18:47:30 -0000 Received: (qmail 28681 invoked by uid 22791); 21 Sep 2012 18:47:26 -0000 X-SWARE-Spam-Status: No, hits=-3.3 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,TW_CP X-Spam-Check-By: sourceware.org Received: from dns1.mips.com (HELO dns1.mips.com) (12.201.5.69) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Sep 2012 18:47:09 +0000 Received: from mailgate1.mips.com (mailgate1.mips.com [12.201.5.111]) by dns1.mips.com (8.13.8/8.13.8) with ESMTP id q8LIl4Ew008080; Fri, 21 Sep 2012 11:47:04 -0700 X-M-MSG: Received: from exchdb01.mips.com (unknown [192.168.36.84]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mailgate1.mips.com (Postfix) with ESMTP id 2CD9C364641; Fri, 21 Sep 2012 11:47:04 -0700 (PDT) Received: from [192.168.65.53] (192.168.65.53) by exchhub01.mips.com (192.168.36.84) with Microsoft SMTP Server id 14.1.270.1; Fri, 21 Sep 2012 11:46:59 -0700 Subject: Re: [PATCH] Optimize MIPS memcpy From: Steve Ellcey To: Maxim Kuvyrkov CC: Andrew T Pinski , "Joseph S. Myers" , In-Reply-To: References: <5044746c.23eb440a.75e2.618f@mx.google.com> <1346771341.14333.20.camel@ubuntu-sellcey> <596797ED-6575-456D-98FD-C13A209DBC49@mentor.com> <1346948701.14333.152.camel@ubuntu-sellcey> <1347376645.14333.319.camel@ubuntu-sellcey> Content-Type: text/plain; charset="UTF-8" Date: Fri, 21 Sep 2012 18:47:00 -0000 Message-ID: <1348253219.6170.82.camel@ubuntu-sellcey> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-EMS-Proccessed: 6LP3oGfGVdcdb8o1aBnt6w== X-EMS-STAMP: sipAgOzn06D/1uNUoY0A1A== Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-09/txt/msg00060.txt.bz2 On Thu, 2012-09-20 at 21:05 +1200, Maxim Kuvyrkov wrote: > What testing was done for this patch, does it pass glibc testsuite? Maxim, I get the same failures with this memcpy as without it when running the glibc testsuite: glibc/localedata/tst-fmon.out glibc/math/test-float.out glibc/math/test-double.out glibc/math/test-ifloat.out glibc/math/test-idouble.out glibc/stdlib/tst-strtod-overflow.out glibc/stdio-common/bug22.out glibc/malloc/tst-trim1.out glibc/nptl/tst-cancel7.out glibc/nptl/tst-cancelx7.out I did find a build problem, the version I sent you sets USE_PREFETCH for any libc build. If building for something like MIPS1 that is not right, so I need to change how that macro is set. Steve Ellcey sellcey@mips.com