From: Mans Rullgard <mans@mansr.com>
To: libc-ports@sourceware.org
Subject: [PATCH] ARM: fix preconfigure
Date: Mon, 25 Mar 2013 12:58:00 -0000 [thread overview]
Message-ID: <1364216301-9993-1-git-send-email-mans@mansr.com> (raw)
After the conversion to autoconf, m4 eats the square brackets causing
CFLAGS to be unconditionally reset. Using 'test' instead of brackets
fixes this.
'preconfigure' manually updated as I have no desire to spend time installing
the precise autofoo versions required.
---
ports/sysdeps/arm/preconfigure | 2 +-
ports/sysdeps/arm/preconfigure.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ports/sysdeps/arm/preconfigure b/ports/sysdeps/arm/preconfigure
index 7ba1749..908cd34 100644
--- a/ports/sysdeps/arm/preconfigure
+++ b/ports/sysdeps/arm/preconfigure
@@ -10,7 +10,7 @@ arm*)
# avoid this, add -fno-unwind-tables here and remove it in
# sysdeps/unix/sysv/linux/arm/configure.in after those tests have
# been run.
- if "${CFLAGS+set}" != "set" ; then
+ if test "${CFLAGS+set}" != "set"; then
CFLAGS="-g -O2"
fi
CFLAGS="$CFLAGS -fno-unwind-tables"
diff --git a/ports/sysdeps/arm/preconfigure.in b/ports/sysdeps/arm/preconfigure.in
index 99f2128..f835795 100644
--- a/ports/sysdeps/arm/preconfigure.in
+++ b/ports/sysdeps/arm/preconfigure.in
@@ -10,7 +10,7 @@ arm*)
# avoid this, add -fno-unwind-tables here and remove it in
# sysdeps/unix/sysv/linux/arm/configure.in after those tests have
# been run.
- if [ "${CFLAGS+set}" != "set" ]; then
+ if test "${CFLAGS+set}" != "set"; then
CFLAGS="-g -O2"
fi
CFLAGS="$CFLAGS -fno-unwind-tables"
--
1.8.1.5
next reply other threads:[~2013-03-25 12:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-25 12:58 Mans Rullgard [this message]
2013-03-26 20:53 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1364216301-9993-1-git-send-email-mans@mansr.com \
--to=mans@mansr.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).