From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8121 invoked by alias); 5 Jun 2013 22:51:50 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 8092 invoked by uid 89); 5 Jun 2013 22:51:44 -0000 X-Spam-SWARE-Status: No, score=-1.1 required=5.0 tests=AWL,BAYES_50,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_YE,SPF_PASS autolearn=no version=3.3.1 Received: from mail-pd0-f179.google.com (HELO mail-pd0-f179.google.com) (209.85.192.179) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Wed, 05 Jun 2013 22:51:43 +0000 Received: by mail-pd0-f179.google.com with SMTP id q11so2483604pdj.10 for ; Wed, 05 Jun 2013 15:51:41 -0700 (PDT) X-Received: by 10.68.59.98 with SMTP id y2mr4929579pbq.135.1370472701815; Wed, 05 Jun 2013 15:51:41 -0700 (PDT) Received: from fremont.twiddle.net (50-194-63-110-static.hfc.comcastbusiness.net. [50.194.63.110]) by mx.google.com with ESMTPSA id qh4sm74548347pac.8.2013.06.05.15.51.39 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 05 Jun 2013 15:51:40 -0700 (PDT) From: Richard Henderson To: libc-ports@sourceware.org Subject: [COMMITTED] BZ #15583: r7 uninitialized in strcpy.S when ARM_HAS_T2 undefined Date: Wed, 05 Jun 2013 22:51:00 -0000 Message-Id: <1370472686-3182-1-git-send-email-rth@twiddle.net> X-SW-Source: 2013-06/txt/msg00006.txt.bz2 --- A shockingly obvious typo. Tested on a15 with CC='gcc -march=armv6', verifying that the ldr version was generated, and running make check with subdirs=string. r~ NEWS | 2 +- ports/ChangeLog.arm | 6 ++++++ ports/sysdeps/arm/armv6/strcpy.S | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index 3068b78..99c0c94 100644 --- a/NEWS +++ b/NEWS @@ -19,7 +19,7 @@ Version 2.18 15336, 15337, 15339, 15342, 15346, 15359, 15361, 15366, 15380, 15381, 15394, 15395, 15405, 15406, 15409, 15416, 15418, 15419, 15423, 15424, 15426, 15429, 15441, 15442, 15448, 15465, 15480, 15485, 15488, 15490, - 15493, 15497, 15506, 15529, 15536, 15553. + 15493, 15497, 15506, 15529, 15536, 15553, 15583. * CVE-2013-0242 Buffer overrun in regexp matcher has been fixed (Bugzilla #15078). diff --git a/ports/ChangeLog.arm b/ports/ChangeLog.arm index 4c73bb3..37eac21 100644 --- a/ports/ChangeLog.arm +++ b/ports/ChangeLog.arm @@ -1,3 +1,9 @@ +2013-06-05 Richard Henderson + + [BZ #15583] + * sysdeps/arm/armv6/strcpy.S (strcpy): Fix register usage in + non ARCH_HAS_T2 case. + 2013-06-05 Joseph Myers * sysdeps/arm/machine-gmon.h: Remove trailing whitespace. diff --git a/ports/sysdeps/arm/armv6/strcpy.S b/ports/sysdeps/arm/armv6/strcpy.S index cd13ff7..69e82d8 100644 --- a/ports/sysdeps/arm/armv6/strcpy.S +++ b/ports/sysdeps/arm/armv6/strcpy.S @@ -89,7 +89,7 @@ ENTRY (strcpy) tst r0, #3 @ Test alignment of DEST movt r7, #0x0101 #else - ldr ip, =0x01010101 + ldr r7, =0x01010101 tst r0, #3 #endif bne .Lunaligned -- 1.8.1.4