From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25159 invoked by alias); 6 Sep 2013 15:42:06 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 25150 invoked by uid 89); 6 Sep 2013 15:42:05 -0000 Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 06 Sep 2013 15:42:05 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,NO_RECEIVED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: multi.imgtec.com Message-ID: <1378482079.5770.293.camel@ubuntu-sellcey> Subject: Re: [patch, mips] Improved memset for MIPS From: Steve Ellcey To: Mike Frysinger CC: Date: Fri, 06 Sep 2013 15:42:00 -0000 In-Reply-To: <201309052041.00545.vapier@gentoo.org> References: <93a232b5-9d0b-4a27-bbb5-16e3ae7c4b89@BAMAIL02.ba.imgtec.org> <201309052041.00545.vapier@gentoo.org> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SEF-Processed: 7_3_0_01192__2013_09_06_16_42_02 X-SW-Source: 2013-09/txt/msg00054.txt.bz2 On Thu, 2013-09-05 at 20:40 -0400, Mike Frysinger wrote: > On Thursday 05 September 2013 13:05:43 Steve Ellcey wrote: > > --- a/ports/sysdeps/mips/memset.S > > +++ b/ports/sysdeps/mips/memset.S > > @@ -1,6 +1,5 @@ > > -/* Copyright (C) 2002-2013 Free Software Foundation, Inc. > > +/* Copyright (C) 2013 Free Software Foundation, Inc. > > err, that's not generally how it works ... we extend the years, but don't > delete them. I am replaced the entire file. While the diff makes it look like some stuff is not replaced, the standard copyright text is about the only thing not completely changed. There are some blank lines and maybe a couple of assembly language psuedo-ops that happen to match up by chance but that is pure coincidence. > > > - Contributed by Hartvig Ekner , 2002. > > what'd he ever do to you ? :p Nothing, but I didn't use any of the old code. > > +#ifdef ANDROID_CHANGES > > i wouldn't think we'd normally accept this kind of stuff, but i guess it's > already been done with the mips memcpy ... > -mike Yes, I am trying to have a common memset, memcpy, and maybe some other routines between glibc, newlib, and android/bionic. Steve Ellcey sellcey@mips.com