public inbox for libc-ports@sourceware.org
 help / color / mirror / Atom feed
From: Steve Ellcey <sellcey@mips.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: <libc-ports@sourceware.org>
Subject: Re: [patch, mips] Improved memset for MIPS
Date: Fri, 06 Sep 2013 16:03:00 -0000	[thread overview]
Message-ID: <1378483403.5770.307.camel@ubuntu-sellcey> (raw)
In-Reply-To: <522957A4.2030400@redhat.com>

On Fri, 2013-09-06 at 00:18 -0400, Carlos O'Donell wrote:

> Two things really: 
> 
> (a) Testing details?
> 
> Could you please elaborate more on "some standalone performance 
> measurements?"
> 
> What specific benchmarks did you run?

Basically, I just wrote and used a test program that does a bunch of
memset's.  Nothing fancy or very intricate.

> What does the glibc microbenchmark show about your changes? Do they
> show a benefit?

I didn't try this, but I can.  Is there anything on the glibc web page
about how to run this benchmark?  Does it happen as part of the standard
'make check'?

> 
> Steve, I trust your experience with MIPS, but I'd like to see all 
> of us drive a little more detail into these performance related
> patches. I'm also curious if the microbenchmark shows a performance
> progression. The glibc community is trying hard to add some objectivity
> to our performance measurements, prevent performance regressions, and
> use the tests to experiment with new implementations.

That sounds reasonable.  I just need a bit of help on where this is and
how to run it.

> (b) the code formatting isn't in line with the project requirements.

I'll fix these up and resubmit when I have the changes (and some more
performance data).

Steve Ellcey
sellcey@mips.com


  reply	other threads:[~2013-09-06 16:03 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-05 17:06 Steve Ellcey 
2013-09-06  0:40 ` Mike Frysinger
2013-09-06 15:42   ` Steve Ellcey
2013-09-06  4:18 ` Carlos O'Donell
2013-09-06 16:03   ` Steve Ellcey [this message]
2013-09-06 17:12     ` Carlos O'Donell
2013-09-06 23:33       ` Steve Ellcey
2013-09-07  2:38         ` Carlos O'Donell
2013-09-10 20:31           ` Steve Ellcey
2013-09-10 21:01             ` Carlos O'Donell
2013-09-10 21:14               ` Steve Ellcey
2013-09-10 22:35                 ` Carlos O'Donell
2013-09-10 22:38                   ` Carlos O'Donell
2013-09-07  5:46         ` Andreas Schwab
2013-09-06 14:31 ` Joseph S. Myers
2013-09-06 15:58   ` Steve Ellcey
2013-09-06 16:09     ` Joseph S. Myers
2013-09-06 16:50       ` Steve Ellcey
2013-09-06 16:59         ` Joseph S. Myers
2013-09-06 17:43           ` Steve Ellcey
2013-09-06 18:57             ` Brooks Moses
2013-09-18 17:41           ` Steve Ellcey
2013-09-19 15:25             ` Carlos O'Donell
2013-09-19 17:02               ` Steve Ellcey
2013-09-20 16:43             ` Joseph S. Myers
2013-09-20 17:32               ` Steve Ellcey
2013-12-12 22:19                 ` Andrew Pinski
2013-12-13  0:01                   ` Carlos O'Donell
2013-12-13  0:14                     ` Steve Ellcey
2013-12-13  0:22                       ` Andrew Pinski
2013-12-13  4:40                       ` Carlos O'Donell
2013-09-06 16:59       ` Steve Ellcey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1378483403.5770.307.camel@ubuntu-sellcey \
    --to=sellcey@mips.com \
    --cc=carlos@redhat.com \
    --cc=libc-ports@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).