From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10473 invoked by alias); 6 Sep 2013 16:50:49 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 10464 invoked by uid 89); 6 Sep 2013 16:50:49 -0000 Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Fri, 06 Sep 2013 16:50:49 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,NO_RECEIVED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: multi.imgtec.com Message-ID: <1378486241.5770.327.camel@ubuntu-sellcey> Subject: Re: [patch, mips] Improved memset for MIPS From: Steve Ellcey To: "Joseph S. Myers" CC: Date: Fri, 06 Sep 2013 16:50:00 -0000 In-Reply-To: References: <93a232b5-9d0b-4a27-bbb5-16e3ae7c4b89@BAMAIL02.ba.imgtec.org> <1378483039.5770.302.camel@ubuntu-sellcey> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SEF-Processed: 7_3_0_01192__2013_09_06_17_50_45 X-SW-Source: 2013-09/txt/msg00059.txt.bz2 On Fri, 2013-09-06 at 16:09 +0000, Joseph S. Myers wrote: > > No. I did most of my testing outside of the glibc testsuite because I > > find the glibc testsuite difficult to run, see > > https://sourceware.org/ml/libc-help/2013-08/msg00040.html for some of my > > problems/questions. I don't believe I have ever managed to do a clean > > You'll need to debug the problems as they indicate something wrong with > your build environment. It's always advised to configure glibc with > --prefix=/usr rather than some other prefix (but there is no requirement > that the dynamic linker actually be installed during testing, you can > ignore the -dynamic-linker= path), and your other error indicates some > inconsistency regarding NO_CTORS_DTORS_SECTIONS. I have found that --prefix=/usr is more of a problem then a help when building general cross compiler toolchains. Using a prefix of /usr triggers various special case code in ports/sysdeps/unix/sysv/linux/mips/configure to put things in lib32 and lib64 and I don't actually want any of that so I use a prefix of /usr/fake instead of /usr. The "undefined reference to `__libc_global_ctors'" has just shown up again in a parallel build, but it seems to go away when I rebuild. I am still trying to understand what is going on with this. > The expectation is that the glibc testsuite is the normal way to test > patches before submission, and string function patches like this need it > to be run for all six relevant ABI variants. I think some flexibility here would be better. There is no floating point code in this routine so running all three ABI's in both hard and soft float modes seems like overkill to me. Testing in big and little endian modes would seem more likely to turn up problems then testing in hard and soft float. Steve Ellcey sellcey@imgtec.com