From: Steve Ellcey <sellcey@mips.com>
To: Carlos O'Donell <carlos@redhat.com>
Cc: "Maciej W. Rozycki" <macro@codesourcery.com>,
"Joseph S. Myers" <joseph@codesourcery.com>,
<libc-ports@sourceware.org>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH] Speed up libm on MIPS
Date: Mon, 23 Sep 2013 16:42:00 -0000 [thread overview]
Message-ID: <1379954515.5770.474.camel@ubuntu-sellcey> (raw)
In-Reply-To: <523F2B7D.7030203@redhat.com>
On Sun, 2013-09-22 at 13:40 -0400, Carlos O'Donell wrote:
> On 09/21/2013 02:47 PM, Maciej W. Rozycki wrote:
> > On Fri, 20 Sep 2013, Carlos O'Donell wrote:
> >
> >>> 2013-09-19 Steve Ellcey <sellcey@mips.com>
> >>>
> >>> * sysdeps/mips/fpu_control.h (_FPU_RC_MASK): New.
> >>> * sysdeps/mips/fpu/fegetround.c (fegetround): Use _FPU_RC_MASK.
> >>> * sysdeps/mips/fpu/fesetround.c (fesetround): Use _FPU_RC_MASK.
> >>
> >> Looks good to me. You should just check this in as an obvious cleanup.
> >
> > Except with a small formatting fix to comply with the GNU Coding
> > http://www.gnu.org/prep/standards/standards.html#Comments
>
> That's right, thanks for catching that :-)
>
> Cheers,
> Carlos.
I was originally trying to match the existing comments, but I went ahead
and did a separate patch to make the existing comments more standard and
then checked in this patch after updating its comment to match the
standard.
Steve Ellcey
sellcey@mips.com
next prev parent reply other threads:[~2013-09-23 16:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-19 22:58 Steve Ellcey
2013-09-20 3:32 ` Carlos O'Donell
2013-09-20 16:51 ` Steve Ellcey
2013-09-20 17:06 ` Carlos O'Donell
2013-09-21 18:47 ` Maciej W. Rozycki
2013-09-22 17:40 ` Carlos O'Donell
2013-09-23 16:42 ` Steve Ellcey [this message]
2013-09-20 15:01 ` Richard Henderson
2013-09-20 15:35 ` Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1379954515.5770.474.camel@ubuntu-sellcey \
--to=sellcey@mips.com \
--cc=carlos@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-ports@sourceware.org \
--cc=macro@codesourcery.com \
--cc=macro@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).