From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27354 invoked by alias); 23 Sep 2013 16:42:05 -0000 Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org Received: (qmail 27341 invoked by uid 89); 23 Sep 2013 16:42:04 -0000 Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 23 Sep 2013 16:42:04 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,NO_RECEIVED,NO_RELAYS autolearn=ham version=3.3.2 X-HELO: multi.imgtec.com Message-ID: <1379954515.5770.474.camel@ubuntu-sellcey> Subject: Re: [PATCH] Speed up libm on MIPS From: Steve Ellcey To: Carlos O'Donell CC: "Maciej W. Rozycki" , "Joseph S. Myers" , , "Maciej W. Rozycki" Date: Mon, 23 Sep 2013 16:42:00 -0000 In-Reply-To: <523F2B7D.7030203@redhat.com> References: <1379631395.5770.445.camel@ubuntu-sellcey> <523BC1B8.4040102@redhat.com> <1379695885.5770.463.camel@ubuntu-sellcey> <523C80A9.6070700@redhat.com> <523F2B7D.7030203@redhat.com> Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit MIME-Version: 1.0 X-SEF-Processed: 7_3_0_01192__2013_09_23_17_41_58 X-SW-Source: 2013-09/txt/msg00123.txt.bz2 On Sun, 2013-09-22 at 13:40 -0400, Carlos O'Donell wrote: > On 09/21/2013 02:47 PM, Maciej W. Rozycki wrote: > > On Fri, 20 Sep 2013, Carlos O'Donell wrote: > > > >>> 2013-09-19 Steve Ellcey > >>> > >>> * sysdeps/mips/fpu_control.h (_FPU_RC_MASK): New. > >>> * sysdeps/mips/fpu/fegetround.c (fegetround): Use _FPU_RC_MASK. > >>> * sysdeps/mips/fpu/fesetround.c (fesetround): Use _FPU_RC_MASK. > >> > >> Looks good to me. You should just check this in as an obvious cleanup. > > > > Except with a small formatting fix to comply with the GNU Coding > > http://www.gnu.org/prep/standards/standards.html#Comments > > That's right, thanks for catching that :-) > > Cheers, > Carlos. I was originally trying to match the existing comments, but I went ahead and did a separate patch to make the existing comments more standard and then checked in this patch after updating its comment to match the standard. Steve Ellcey sellcey@mips.com