From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16272 invoked by alias); 11 Mar 2013 13:17:33 -0000 Received: (qmail 16174 invoked by uid 22791); 11 Mar 2013 13:17:32 -0000 X-SWARE-Spam-Status: No, hits=-9.7 required=5.0 tests=AWL,BAYES_00,FRT_OFFER2,KHOP_PGP_SIGNED,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI X-Spam-Check-By: sourceware.org Received: from cantor2.suse.de (HELO mx2.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 11 Mar 2013 13:17:28 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 79ECBA51B8; Mon, 11 Mar 2013 14:17:27 +0100 (CET) From: Andreas Jaeger To: Thomas Schwinge Cc: "Joseph S. Myers" , libc-ports@sourceware.org Subject: Re: [PATCH 5/6] Use bits/mman-linux.h for MIPS Date: Mon, 11 Mar 2013 13:17:00 -0000 Message-ID: <1816722.SxCCjHGSiY@byrd> User-Agent: KMail/4.10 (Linux/3.8.2-1-desktop; KDE/4.10.0; x86_64; ; ) In-Reply-To: <871ubmxh5i.fsf@kepler.schwinge.homeip.net> References: <1362512224-26951-1-git-send-email-aj@suse.de> <5137652E.5010803@suse.com> <871ubmxh5i.fsf@kepler.schwinge.homeip.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart5485341.pPEZuK1h1q"; micalg="pgp-sha1"; protocol="application/pgp-signature" Content-Transfer-Encoding: quoted-printable Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2013-03/txt/msg00088.txt.bz2 --nextPart5485341.pPEZuK1h1q Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Content-length: 1883 On Monday, March 11, 2013 13:19:53 Thomas Schwinge wrote: > Hi! >=20 > On Wed, 06 Mar 2013 16:47:58 +0100, Andreas Jaeger =20 wrote: > > 2013-03-06 Andreas Jaeger > >=20 > > * sysdeps/unix/sysv/linux/bits/mman-linux.h (MAP_ANONYMOUS):=20 Allow > > definition via __MAP_ANONYMOUS. > >=20=09 > > ChangeLog.mips: > > * sysdeps/unix/sysv/linux/mips/bits/mman.h: Remove all defines > > provided by bits/mman-linux.h and include . > > (__MAP_ANONYMOUS): Define. >=20 > With the current master branch (including this change as commit > 664a9ce4ca40feabff781fff044c93a43ae15b59), I get redefinition warnings > for MAP_ANONYMOUS; solved by the following patch. OK to push? >=20 > ports/ChangeLog.mips > * sysdeps/unix/sysv/linux/mips/bits/mman.h [__USE_MISC] > (MAP_ANONYMOUS): Don't define. >=20 > diff --git ports/sysdeps/unix/sysv/linux/mips/bits/mman.h > ports/sysdeps/unix/sysv/linux/mips/bits/mman.h index 883f947..b327795 > 100644 > --- ports/sysdeps/unix/sysv/linux/mips/bits/mman.h > +++ ports/sysdeps/unix/sysv/linux/mips/bits/mman.h > @@ -26,7 +26,6 @@ > /* These are Linux-specific. */ > #ifdef __USE_MISC > # define MAP_NORESERVE 0x0400 /* don't check for=20 reservations */ > -# define MAP_ANONYMOUS 0x0800 /* don't use a file */ > # define MAP_GROWSDOWN 0x1000 /* stack-like segment */ > # define MAP_DENYWRITE 0x2000 /* ETXTBSY */ > # define MAP_EXECUTABLE 0x4000 /* mark it as an executable */ Yes, that was the intention - to remove this define. I would consider this an obvious cleanup, Thanks, Andreas --=20 Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn,Jennifer Guild,Felix Imend=F6rffer,HRB16746 (AG N=FCrnberg) GPG fingerprint =3D 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126 --nextPart5485341.pPEZuK1h1q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-length: 190 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iD8DBQBRPdlmOJpWPMJyoSYRAhmOAJ9h7o/MbiBGiPOPdZ6AInjy03jnVACfYy5/ hyUNK7tRDaq+Er8iA42HUT8= =1+57 -----END PGP SIGNATURE----- --nextPart5485341.pPEZuK1h1q--