From: David Holsgrove <david.holsgrove@xilinx.com>
To: Andreas Jaeger <aj@suse.com>, Mike Frysinger <vapier@gentoo.org>
Cc: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>,
"libc-ports@sourceware.org" <libc-ports@sourceware.org>,
John Williams <jwilliams@xilinx.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
Vinod Kathail <vinodk@xilinx.com>, Tom Shui <tshui@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
Nagaraju Mekala <nmekala@xilinx.com>
Subject: RE: [PATCH 2/3 elf] Add MicroBlaze support to elf.h
Date: Thu, 29 Nov 2012 08:23:00 -0000 [thread overview]
Message-ID: <1fffca58-9cf2-4c29-b230-6346e944e1ef@AM1EHSMHS020.ehs.local> (raw)
In-Reply-To: <50B71717.1090100@suse.com>
Hi Andreas,
> -----Original Message-----
> From: Andreas Jaeger [mailto:aj@suse.com]
> Sent: Thursday, 29 November 2012 6:05 pm
> To: Mike Frysinger
> Cc: libc-alpha@sourceware.org; David Holsgrove; libc-ports@sourceware.org;
> John Williams; Edgar E. Iglesias; Vinod Kathail; Tom Shui; Vidhumouli Hunsigida;
> Nagaraju Mekala
> Subject: Re: [PATCH 2/3 elf] Add MicroBlaze support to elf.h
>
> On 11/29/2012 08:58 AM, Mike Frysinger wrote:
> > On Thursday 29 November 2012 02:16:22 Andreas Jaeger wrote:
> >> On 11/29/2012 06:28 AM, David Holsgrove wrote:
> >>> +#define EM_NEW_MICROBLAZE 0xbd /* Xilinx MicroBlaze */
> >>> +#define EM_MICROBLAZE 0xbaab
> >>
> >> Are any of these official values? The comment above asks for hig numbers
> >> and 0xbd is not height.
> >
> > the first one is, but should be renamed. from binutils:
> > #define EM_MICROBLAZE 189 /* Xilinx MicroBlaze 32-bit RISC soft processor
> core */
>
> In that case, it should be sorted at the proper place - directly after
> EM_TILEPRO.
>
> David, we've just frozen glibc for development, these kind of patches
> are too late for glibc 2.17. Please update them and they will get
> properly reviewed and added once 2.17 is released.
>
Thanks for the heads up, does this apply to commits self-contained to libc-ports
also? (can't hurt to ask :-) )
> Btw. do you have copyright announcement with the FSF?
Yes, Xilinx has copyright assignments with FSF, completed in January 2010.
David
> Andreas
> --
> Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn,Jennifer Guild,Felix Imendörffer,HRB16746 (AG Nürnberg)
> GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126
next prev parent reply other threads:[~2012-11-29 8:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-29 5:29 David Holsgrove
2012-11-29 6:04 ` [PATCH] Adding MicroBlaze support to elf/elf.h David Holsgrove
2012-11-29 7:16 ` [PATCH 2/3 elf] Add MicroBlaze support to elf.h Andreas Jaeger
2012-11-29 7:58 ` Mike Frysinger
2012-11-29 8:04 ` Andreas Jaeger
2012-11-29 8:23 ` David Holsgrove [this message]
2012-11-29 16:06 ` Joseph S. Myers
2012-11-29 16:11 ` Carlos O'Donell
2012-11-29 16:20 ` Joseph S. Myers
2012-11-29 8:03 ` David Holsgrove
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1fffca58-9cf2-4c29-b230-6346e944e1ef@AM1EHSMHS020.ehs.local \
--to=david.holsgrove@xilinx.com \
--cc=aj@suse.com \
--cc=edgar.iglesias@gmail.com \
--cc=jwilliams@xilinx.com \
--cc=libc-alpha@sourceware.org \
--cc=libc-ports@sourceware.org \
--cc=nmekala@xilinx.com \
--cc=tshui@xilinx.com \
--cc=vapier@gentoo.org \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).