From: Mike Frysinger <vapier@gentoo.org>
To: libc-ports@sourceware.org
Cc: Guillem Jover <guillem@hadrons.org>
Subject: Re: [PATCH ports] Use __unused0 instead of __unused for user visible struct members
Date: Mon, 02 Jan 2012 06:06:00 -0000 [thread overview]
Message-ID: <201201020106.15682.vapier@gentoo.org> (raw)
In-Reply-To: <20120102031859.GA11067@gaara.hadrons.org>
[-- Attachment #1: Type: Text/Plain, Size: 930 bytes --]
On Sunday 01 January 2012 22:18:59 Guillem Jover wrote:
> On BSD systems __unused has traditionally been defined to mean the
> equivalent of gcc's __attribute__((__unused__)). The problem comes when
> defining such macro while trying to build unmodified source code with
> BSD origins on systems with glibc ports headers. Separate patches have
> been sent to fix the same issue on Linux kernel headers and the main
> glibc project.
don't define __unused before including C library headers. problem solved.
> This patch renames the user visible struct members from __unused to
> __unused0 to not cause compilation failures due to that macro, which
> should not be a problem as those members are supposed to be private
> anyway.
the main tree needs modification in more places. so unless you can convince
drepper to make the modification to the main tree, updating the ports doesn't
make much sense.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-02 6:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-02 3:19 Guillem Jover
2012-01-02 6:06 ` Mike Frysinger [this message]
2012-01-04 7:12 ` Guillem Jover
2012-01-04 11:57 ` Joseph S. Myers
2012-01-09 5:35 ` Guillem Jover
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201020106.15682.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=guillem@hadrons.org \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).