From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24608 invoked by alias); 2 Jan 2012 06:06:29 -0000 Received: (qmail 24599 invoked by uid 22791); 2 Jan 2012 06:06:27 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp.gentoo.org (HELO smtp.gentoo.org) (140.211.166.183) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 02 Jan 2012 06:06:12 +0000 Received: from vapier.localnet (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id 364551B400B; Mon, 2 Jan 2012 06:06:11 +0000 (UTC) From: Mike Frysinger To: libc-ports@sourceware.org Subject: Re: [PATCH ports] Use __unused0 instead of __unused for user visible struct members Date: Mon, 02 Jan 2012 06:06:00 -0000 User-Agent: KMail/1.13.7 (Linux/3.1.0-atsc; KDE/4.6.5; x86_64; ; ) Cc: Guillem Jover References: <20120102031859.GA11067@gaara.hadrons.org> In-Reply-To: <20120102031859.GA11067@gaara.hadrons.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart3802703.7vC9IWFyoy"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit Message-Id: <201201020106.15682.vapier@gentoo.org> X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-01/txt/msg00001.txt.bz2 --nextPart3802703.7vC9IWFyoy Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-length: 919 On Sunday 01 January 2012 22:18:59 Guillem Jover wrote: > On BSD systems __unused has traditionally been defined to mean the > equivalent of gcc's __attribute__((__unused__)). The problem comes when > defining such macro while trying to build unmodified source code with > BSD origins on systems with glibc ports headers. Separate patches have > been sent to fix the same issue on Linux kernel headers and the main > glibc project. don't define __unused before including C library headers. problem solved. > This patch renames the user visible struct members from __unused to > __unused0 to not cause compilation failures due to that macro, which > should not be a problem as those members are supposed to be private > anyway. the main tree needs modification in more places. so unless you can convinc= e=20 drepper to make the modification to the main tree, updating the ports doesn= 't=20 make much sense. -mike --nextPart3802703.7vC9IWFyoy Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. Content-length: 836 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (GNU/Linux) iQIcBAABAgAGBQJPAUlXAAoJEEFjO5/oN/WBO90P/iTz2qZDEvWUo6K8NjqspI3j nzrwxneaqik2Qwv7ZojN8co6rjrkjyffndMQQpjcB1H4gRDspzDYx9qj+9EKrI0y A3oeiPh545o05NiX9r7lbT5zb1zjzAK3FpMxisdIpi2L665JsAJuqkQdG3Ada/DZ U0qo9gB7/TE61xmXWTsVYhdc5SEp6if3TFPGTCngMoMBgXY01qtbFPQZF1Lfry7F jtZHPKDRnQurLmAzwnl6y8XEkisFUT0MQrM1ZDSmqfA2dnC2dlKZAMAMsquz8FN9 p859hcMa7Coy7SMcM03p4cOfRa+P4Z4ZhynuWPwd59ytBJy7f4zC8M0LmOIWrr/I YeXGPvMO+aT8WBQ3vEakJ4/Q3n1u8np9rw/C4+PjbPkOQImizl/EZ/CbHeF+UZc0 MOFN2wZNCbd2BvRfCxeOu9phVGTGVs174HTW/Y0RWiBwZoVKFsgpnZGR180TcN/1 T1fc0b1qz1pVMQPYbf/Gqpg90Tg7iQCJgqLj0+uFivZKgK5rrh35snAhhj+n8yOw 7vYKylxMLbunchk6Iz0hAvnVKroj6XQTeypwC+2IXw2UAlv7/9h6/ngKO3nbW/n+ 2f7IcQQVfBMbYNsf3DLwhpel8RXZcz5DCQeAsV39nh16C6sfLQK3+Fodk59A6d5q 2Pu1V5/WnFl7m+FXtTq3 =mOE0 -----END PGP SIGNATURE----- --nextPart3802703.7vC9IWFyoy--