From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26427 invoked by alias); 15 Feb 2012 21:12:51 -0000 Received: (qmail 26392 invoked by uid 22791); 15 Feb 2012 21:12:49 -0000 X-SWARE-Spam-Status: No, hits=-1.7 required=5.0 tests=AWL,BAYES_00,TW_CP X-Spam-Check-By: sourceware.org Received: from shards.monkeyblade.net (HELO shards.monkeyblade.net) (198.137.202.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 15 Feb 2012 21:12:07 +0000 Received: from localhost (nat-pool-rdu.redhat.com [66.187.233.202]) (authenticated bits=0) by shards.monkeyblade.net (8.14.4/8.14.4) with ESMTP id q1FLC018025546 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NO); Wed, 15 Feb 2012 13:12:01 -0800 Date: Wed, 15 Feb 2012 21:12:00 -0000 Message-Id: <20120215.161200.446859972996505543.davem@davemloft.net> To: roland@hack.frob.com Cc: joseph@codesourcery.com, libc-alpha@sourceware.org, libc-ports@sourceware.org Subject: Re: Arch maintainers: new approach for crti.o and crtn.o From: David Miller In-Reply-To: <20120214203736.E56FA2C080@topped-with-meat.com> References: <20120214200953.71FD12C081@topped-with-meat.com> <20120214.152357.1056020502119248076.davem@davemloft.net> <20120214203736.E56FA2C080@topped-with-meat.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-02/txt/msg00054.txt.bz2 From: Roland McGrath Date: Tue, 14 Feb 2012 12:37:36 -0800 (PST) >> Are you then going to do something with symlinks or similar to end up >> with the crt{n,i}.o names in the end? > > It seems likely that having those names will make things easiest all around. > So yes, I'd figured we'd probably have: > > $(objpfx)crti.o $(objpfx)crtn.o: $(objpfx)%.o: $(objpfx)%.os > ln -f $< $@ > > or something like that. Ok, for now I've checked in the following using the CPPFLAGS approach so we can make forward progress. I guess only s390 is left using the initfini.c crud now? -------------------- Move sparc away from the deprecated inifini.c scheme. / * sysdeps/sparc/Makefile: Add -fPIC when building crt{i,n}.S * sysdeps/sparc/crti.S: New file. * sysdeps/sparc/crtn.S: New file. * sysdeps/sparc/sparc32/Makefile: Remove initfini handling. * sysdeps/sparc/sparc64/Makefile: Likewise. nptl/ * sysdeps/sparc/Makefile: Add -fPIC when building pt-crti.S and crtn.S --- ChangeLog | 8 +++ nptl/ChangeLog | 4 ++ nptl/sysdeps/sparc/Makefile | 5 ++ sysdeps/sparc/Makefile | 2 + sysdeps/sparc/crti.S | 104 ++++++++++++++++++++++++++++++++++++++++ sysdeps/sparc/crtn.S | 45 +++++++++++++++++ sysdeps/sparc/sparc32/Makefile | 4 -- sysdeps/sparc/sparc64/Makefile | 4 -- 8 files changed, 168 insertions(+), 8 deletions(-) create mode 100644 sysdeps/sparc/crti.S create mode 100644 sysdeps/sparc/crtn.S diff --git a/ChangeLog b/ChangeLog index cb00422..131caa6 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2012-02-16 David S. Miller + + * sysdeps/sparc/Makefile: Add -fPIC when building crt{i,n}.S + * sysdeps/sparc/crti.S: New file. + * sysdeps/sparc/crtn.S: New file. + * sysdeps/sparc/sparc32/Makefile: Remove initfini handling. + * sysdeps/sparc/sparc64/Makefile: Likewise. + 2012-02-15 Mike Frysinger * sysdeps/unix/sysv/linux/getcwd.c: Include sys/param.h. diff --git a/nptl/ChangeLog b/nptl/ChangeLog index 657c2b0..bda2334 100644 --- a/nptl/ChangeLog +++ b/nptl/ChangeLog @@ -1,3 +1,7 @@ +2012-02-16 David S. Miller + + * sysdeps/sparc/Makefile: Add -fPIC when building pt-crti.S and crtn.S + 2012-02-15 Marek Polacek * sysdeps/unix/sysv/linux/x86_64/Makefile: Remove file. diff --git a/nptl/sysdeps/sparc/Makefile b/nptl/sysdeps/sparc/Makefile index 81bddf6..5372867 100644 --- a/nptl/sysdeps/sparc/Makefile +++ b/nptl/sysdeps/sparc/Makefile @@ -1,3 +1,8 @@ ifeq ($(subdir),csu) gen-as-const-headers += tcb-offsets.sym endif + +ifeq ($(subdir),nptl) +CPPFLAGS-pt-crti.S += -fPIC +CPPFLAGS-crtn.S += -fPIC +endif diff --git a/sysdeps/sparc/Makefile b/sysdeps/sparc/Makefile index 735e4a4..45609d5 100644 --- a/sysdeps/sparc/Makefile +++ b/sysdeps/sparc/Makefile @@ -14,4 +14,6 @@ endif ifeq ($(subdir),csu) # get offset to rtld_global._dl_hwcap gen-as-const-headers += rtld-global-offsets.sym +CPPFLAGS-crti.S += -fPIC +CPPFLAGS-crtn.S += -fPIC endif diff --git a/sysdeps/sparc/crti.S b/sysdeps/sparc/crti.S new file mode 100644 index 0000000..adb1b29 --- /dev/null +++ b/sysdeps/sparc/crti.S @@ -0,0 +1,104 @@ +/* Special .init and .fini section support for sparc. + Copyright (C) 1995-2012 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + In addition to the permissions in the GNU Lesser General Public + License, the Free Software Foundation gives you unlimited + permission to link the compiled version of this file with other + programs, and to distribute those programs without any restriction + coming from the use of this file. (The GNU Lesser General Public + License restrictions do apply in other respects; for example, they + cover modification of the file, and distribution when not linked + into another program.) + + Note that people who make modified versions of this file are not + obligated to grant this special exception for their modified + versions; it is their choice whether to do so. The GNU Lesser + General Public License gives permission to release a modified + version without this exception; this exception also makes it + possible to release a modified version which carries forward this + exception. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* crti.S puts a function prologue at the beginning of the .init and + .fini sections and defines global symbols for those addresses, so + they can be called as functions. The symbols _init and _fini are + magic and cause the linker to emit DT_INIT and DT_FINI. */ + +#include +#include + +#ifndef PREINIT_FUNCTION +# define PREINIT_FUNCTION __gmon_start__ +#endif + +#ifndef PREINIT_FUNCTION_WEAK +# define PREINIT_FUNCTION_WEAK 1 +#endif + +#if PREINIT_FUNCTION_WEAK + weak_extern (PREINIT_FUNCTION) +#else + .hidden PREINIT_FUNCTION +#endif + +#ifdef __arch64__ +#define STACKFRAME_SIZE 176 +#define GOT_LOAD ldx +#else +#define STACKFRAME_SIZE 96 +#define GOT_LOAD ld +#endif + + .section .init,"ax",@progbits + .p2align 2 + .globl _init + .type _init, @function +_init: + save %sp, -STACKFRAME_SIZE, %sp +#if PREINIT_FUNCTION_WEAK + sethi %hi(_GLOBAL_OFFSET_TABLE_-4), %l7 + call __sparc_get_pc_thunk.l7 + add %l7, %lo(_GLOBAL_OFFSET_TABLE_+4), %l7 + sethi %hi(PREINIT_FUNCTION), %g1 + or %g1, %lo(PREINIT_FUNCTION), %g1 + GOT_LOAD [%l7 + %g1], %g1 + cmp %g1, 0 + be 1f + nop + call PREINIT_FUNCTION + nop +1: +#else + call PREINIT_FUNCTION + nop +#endif + + .section .fini,"ax",@progbits + .p2align 2 + .globl _fini + .type _fini, @function +_fini: + save %sp, -STACKFRAME_SIZE, %sp + + .section .text.__sparc_get_pc_thunk.l7,"axG",@progbits,__sparc_get_pc_thunk.l7,comdat + .p2align 2 + .weak __sparc_get_pc_thunk.l7 + .hidden __sparc_get_pc_thunk.l7 + .type __sparc_get_pc_thunk.l7, #function +__sparc_get_pc_thunk.l7: + jmp %o7 + 8 + add %o7, %l7, %l7 diff --git a/sysdeps/sparc/crtn.S b/sysdeps/sparc/crtn.S new file mode 100644 index 0000000..8f3e89a --- /dev/null +++ b/sysdeps/sparc/crtn.S @@ -0,0 +1,45 @@ +/* Special .init and .fini section support for sparc. + Copyright (C) 1995-2012 Free Software Foundation, Inc. + This file is part of the GNU C Library. + + The GNU C Library is free software; you can redistribute it and/or + modify it under the terms of the GNU Lesser General Public + License as published by the Free Software Foundation; either + version 2.1 of the License, or (at your option) any later version. + + In addition to the permissions in the GNU Lesser General Public + License, the Free Software Foundation gives you unlimited + permission to link the compiled version of this file with other + programs, and to distribute those programs without any restriction + coming from the use of this file. (The GNU Lesser General Public + License restrictions do apply in other respects; for example, they + cover modification of the file, and distribution when not linked + into another program.) + + Note that people who make modified versions of this file are not + obligated to grant this special exception for their modified + versions; it is their choice whether to do so. The GNU Lesser + General Public License gives permission to release a modified + version without this exception; this exception also makes it + possible to release a modified version which carries forward this + exception. + + The GNU C Library is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU + Lesser General Public License for more details. + + You should have received a copy of the GNU Lesser General Public + License along with the GNU C Library; if not, see + . */ + +/* crtn.S puts function epilogues in the .init and .fini sections + corresponding to the prologues in crti.S. */ + + .section .init,"ax",@progbits + jmp %i7 + 8 + restore + + .section .fini,"ax",@progbits + jmp %i7 + 8 + restore diff --git a/sysdeps/sparc/sparc32/Makefile b/sysdeps/sparc/sparc32/Makefile index cc2bb08..fb1adaf 100644 --- a/sysdeps/sparc/sparc32/Makefile +++ b/sysdeps/sparc/sparc32/Makefile @@ -19,10 +19,6 @@ ifeq ($(subdir),gnulib) sysdep_routines = dotmul umul $(divrem) alloca endif # gnulib -ifeq ($(subdir),csu) -CFLAGS-initfini.s += -mcpu=v7 -endif - # We distribute these files, even though they are generated, # so as to avoid the need for a functioning m4 to build the library. divrem := sdiv udiv rem urem diff --git a/sysdeps/sparc/sparc64/Makefile b/sysdeps/sparc/sparc64/Makefile index 1a859df..fb8b011 100644 --- a/sysdeps/sparc/sparc64/Makefile +++ b/sysdeps/sparc/sparc64/Makefile @@ -3,10 +3,6 @@ sysdep_routines += hp-timing elide-routines.os += hp-timing endif -ifeq ($(subdir),csu) -CFLAGS-initfini.s += -mcpu=v9 -endif - ifeq ($(subdir),string) sysdep_routines += align-cpy endif -- 1.7.6.401.g6a319