From: Mike Frysinger <vapier@gentoo.org>
To: libc-ports@sourceware.org
Cc: "Carlos O'Donell" <carlos_odonell@mentor.com>,
Andrew Haley <aph@redhat.com>,
Roland McGrath <roland@hack.frob.com>,
steve.mcintyre@linaro.org, michael.hope@linaro.org
Subject: Re: [WIP] glibc: Use /lib/ld-linux-armhf.so.3 for ARM's -mfloat-abi=hard ABI.
Date: Fri, 27 Apr 2012 02:18:00 -0000 [thread overview]
Message-ID: <201204262219.36774.vapier@gentoo.org> (raw)
In-Reply-To: <4F99B990.7020300@mentor.com>
[-- Attachment #1: Type: Text/Plain, Size: 888 bytes --]
On Thursday 26 April 2012 17:09:36 Carlos O'Donell wrote:
> --- sysdeps/arm/preconfigure (revision 368507)
> +++ sysdeps/arm/preconfigure (working copy)
>
> + armhf_dynamic_linker="ld-linux-armhf.so.3"
> + if `echo "$libc_cv_compiler_dynlinker_default" | grep
> "$armhf_dynamic_linker" >& /dev/null`; then
not that it matters as it sounds like this is going to be rewritten, but
there's no need for grep here. you can use a case statement:
case $libc_cv_compiler_dynlinker_default in
*$armhf_dynamic_linker*)
... hard float ...
;;
*)
... soft float ...
;;
esac
also, what's with the back ticks ? i think you just wanted:
if echo ... | grep ... ; then
rather than:
if `echo ... | grep ...` ; then
and you don't want to use ">&" like that ... it's a bashism. `grep -q` would
be better, or the POSIX ">/dev/null 2>&1".
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-27 2:18 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-13 17:27 New path for ld.so on ARM hard fp Andrew Haley
2012-04-13 17:29 ` Andrew Haley
2012-04-13 17:35 ` Roland McGrath
2012-04-14 16:35 ` Carlos O'Donell
2012-04-23 8:42 ` Andrew Haley
2012-04-26 3:41 ` Carlos O'Donell
2012-04-26 21:09 ` [WIP] glibc: Use /lib/ld-linux-armhf.so.3 for ARM's -mfloat-abi=hard ABI Carlos O'Donell
2012-04-26 21:43 ` Roland McGrath
2012-04-26 22:03 ` Joseph S. Myers
2012-04-26 22:07 ` Roland McGrath
2012-05-05 21:06 ` Carlos O'Donell
2012-05-05 21:48 ` Joseph S. Myers
2012-05-05 21:52 ` Carlos O'Donell
2012-05-05 23:17 ` Joseph S. Myers
2012-05-06 2:18 ` Carlos O'Donell
2012-05-06 12:13 ` Joseph S. Myers
2012-05-06 21:36 ` Carlos O'Donell
2012-05-06 22:41 ` Joseph S. Myers
2012-05-07 18:47 ` Roland McGrath
2012-05-07 18:57 ` Carlos O'Donell
2012-05-07 19:55 ` Roland McGrath
2012-05-07 20:00 ` Carlos O'Donell
2012-05-07 20:00 ` Carlos O'Donell
2012-05-07 19:11 ` Joseph S. Myers
2012-05-07 19:41 ` Roland McGrath
2012-05-07 20:52 ` Joseph S. Myers
2012-05-07 21:31 ` Roland McGrath
2012-05-01 4:48 ` Khem Raj
2012-05-01 10:09 ` Joseph S. Myers
2012-04-27 2:18 ` Mike Frysinger [this message]
2012-04-27 12:57 ` Carlos O'Donell
2012-04-19 19:49 ` New path for ld.so on ARM hard fp Joseph S. Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201204262219.36774.vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=aph@redhat.com \
--cc=carlos_odonell@mentor.com \
--cc=libc-ports@sourceware.org \
--cc=michael.hope@linaro.org \
--cc=roland@hack.frob.com \
--cc=steve.mcintyre@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).