From: Chris Metcalf <cmetcalf@tilera.com>
To: <libc-ports@sourceware.org>
Subject: [PATCH 11/14] tile: fix bug in CFI definitions for clone.S
Date: Mon, 14 May 2012 19:59:00 -0000 [thread overview]
Message-ID: <201205141959.q4EJxS8X007564@farm-0002.internal.tilera.com> (raw)
In-Reply-To: <4FB161CE.6070905@tilera.com>
We were missing a critical cfi_def_cfa_offset call in .Lthread_start
which caused backtracing to get badly confused for threads.
---
ChangeLog.tile | 4 ++++
sysdeps/unix/sysv/linux/tile/nptl/clone.S | 3 ++-
2 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/ChangeLog.tile b/ChangeLog.tile
index f2eb35a..ae048dd 100644
--- a/ChangeLog.tile
+++ b/ChangeLog.tile
@@ -1,5 +1,9 @@
2012-05-12 Chris Metcalf <cmetcalf@tilera.com>
+ * sysdeps/unix/sysv/linux/tile/nptl/clone.S: Add missing CFI.
+
+2012-05-12 Chris Metcalf <cmetcalf@tilera.com>
+
* sysdeps/tile/tls-macros.h: Fix buggy TLS_GD, etc., macros.
2012-05-12 Chris Metcalf <cmetcalf@tilera.com>
diff --git a/sysdeps/unix/sysv/linux/tile/nptl/clone.S b/sysdeps/unix/sysv/linux/tile/nptl/clone.S
index eaa2fd6..de4fa13 100644
--- a/sysdeps/unix/sysv/linux/tile/nptl/clone.S
+++ b/sysdeps/unix/sysv/linux/tile/nptl/clone.S
@@ -1,4 +1,4 @@
-/* Copyright (C) 2011 Free Software Foundation, Inc.
+/* Copyright (C) 2011-2012 Free Software Foundation, Inc.
This file is part of the GNU C Library.
Contributed by Chris Metcalf <cmetcalf@tilera.com>, 2011.
@@ -167,6 +167,7 @@ ENTRY (__clone)
in getpid(). Otherwise (if CLONE_VM isn't set), it's a
fork-like clone, and we go ahead and write the cached values
from the true system pid (retrieved via __NR_getpid syscall). */
+ cfi_def_cfa_offset (FRAME_SIZE)
#ifdef __tilegx__
{
moveli r0, hw1_last(CLONE_VM)
--
1.6.5.2
next prev parent reply other threads:[~2012-05-14 19:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-14 19:49 [PATCH 00/14] Updates to tile architecture for 2.16 Chris Metcalf
2012-05-14 19:56 ` [PATCH 01/14] Add _SNSECONDS_T_TYPE for linux-generic Chris Metcalf
2012-05-14 19:57 ` [PATCH 03/14] tile: update pthread_attr_t and struct siginfo names Chris Metcalf
2012-05-14 19:57 ` [PATCH 04/14] tile: remove stale #define of ELF_MACHINE_PLTREL_OVERLAP Chris Metcalf
2012-05-14 19:57 ` [PATCH 02/14] tile: Remove elf/ and create crti.S/crtn.S Chris Metcalf
2012-05-14 19:58 ` [PATCH 07/14] tile: avoid using _LP64 Chris Metcalf
2012-05-14 19:58 ` [PATCH 05/14] linux-generic: add wordsize-32 version of prlimit64/fanotify syscalls Chris Metcalf
2012-05-14 19:58 ` [PATCH 06/14] tile: support stackguard-macros.h header Chris Metcalf
2012-05-14 19:58 ` [PATCH 08/14] tile: allow memcpy(p, p, n) without corrupting memory at "p" Chris Metcalf
2012-05-14 19:59 ` [PATCH 09/14] tilegx: small performance fix for string routines Chris Metcalf
2012-05-14 19:59 ` Chris Metcalf [this message]
2012-05-14 19:59 ` [PATCH 10/14] tile: fix broken TLS_GD macros Chris Metcalf
2012-05-14 19:59 ` [PATCH 12/14] tile: add include <features.h> to <sys/dataplane.h> Chris Metcalf
2012-05-14 20:00 ` [PATCH 13/14] tile: align stack for tilegx32 Chris Metcalf
2012-05-14 20:02 ` [PATCH 14/14] tile: add abilist files Chris Metcalf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201205141959.q4EJxS8X007564@farm-0002.internal.tilera.com \
--to=cmetcalf@tilera.com \
--cc=libc-ports@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).