From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25200 invoked by alias); 15 May 2012 20:46:29 -0000 Received: (qmail 25192 invoked by uid 22791); 15 May 2012 20:46:28 -0000 X-SWARE-Spam-Status: No, hits=-2.8 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED X-Spam-Check-By: sourceware.org Received: from toast.topped-with-meat.com (HELO topped-with-meat.com) (204.197.218.159) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 15 May 2012 20:46:06 +0000 Received: by topped-with-meat.com (Postfix, from userid 5281) id 037152C063; Tue, 15 May 2012 13:46:06 -0700 (PDT) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit From: Roland McGrath To: Chris Metcalf Cc: Subject: Re: [PATCH] linux-generic: avoid "redefined" warnings for open_not_cancel{,_2} In-Reply-To: Chris Metcalf's message of Tuesday, 15 May 2012 16:37:51 -0400 <4FB2BE9F.1090307@tilera.com> References: <201205152020.q4FKKcxp014005@farm-0002.internal.tilera.com> <20120515202251.3C6D72C0A2@topped-with-meat.com> <4FB2BE9F.1090307@tilera.com> Message-Id: <20120515204606.037152C063@topped-with-meat.com> Date: Tue, 15 May 2012 20:46:00 -0000 X-CMAE-Score: 0 X-CMAE-Analysis: v=2.0 cv=e8d9udV/ c=1 sm=1 a=kxjryZT1TqoA:10 a=Z6MIti7PxpgA:10 a=kj9zAlcOel0A:10 a=8eEt0YcqIIs8c9AEyfcA:9 a=CjuIK1q_8ugA:10 a=WkljmVdYkabdwxfqvArNOQ==:117 X-IsSubscribed: yes Mailing-List: contact libc-ports-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: libc-ports-owner@sourceware.org X-SW-Source: 2012-05/txt/msg00083.txt.bz2 > Fair enough, but my concern was: what guard? Should I be very explicit and use > > #ifndef _SYSDEPS_UNIX_SYSV_LINUX_GENERIC_NOT_CANCEL_H > # define _SYSDEPS_UNIX_SYSV_LINUX_GENERIC_NOT_CANCEL_H > ... > #endif That is OK but we've usually been not quite so verbose and just use a name that is sufficiently unique, e.g. _LINUX_GENERIC_NOT_CANCEL_H.